Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 8520011: Print Preview: Make print preview tab modal. (try 2) (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
CC:
chromium-reviews, arv (Not doing code reviews), Paweł Hajdan Jr.
Visibility:
Public.

Description

Print Preview: Make print preview tab modal. (try 2) BUG=none TEST=none Original review: http://codereview.chromium.org/8136027/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110190

Patch Set 1 : previous CL #

Patch Set 2 : disable tests in touch_ui, fix failing test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+599 lines, -708 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.h View 3 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/printing/background_printing_manager.cc View 4 chunks +3 lines, -67 lines 0 comments Download
M chrome/browser/printing/print_preview_message_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_message_handler.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller.cc View 1 9 chunks +194 lines, -101 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_browsertest.cc View 3 chunks +59 lines, -169 lines 0 comments Download
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 1 7 chunks +36 lines, -65 lines 0 comments Download
M chrome/browser/printing/print_view_manager.h View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/printing/print_view_manager.cc View 4 chunks +4 lines, -20 lines 0 comments Download
M chrome/browser/resources/print_preview/print_header.js View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 8 chunks +22 lines, -39 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 4 chunks +17 lines, -17 lines 1 comment Download
M chrome/browser/ui/browser_list_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/cloud_print_signin_dialog.cc View 4 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_html_ui.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview_data_source.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.h View 3 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler.cc View 15 chunks +11 lines, -60 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler_unittest.cc View 1 10 chunks +42 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.h View 5 chunks +18 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui.cc View 5 chunks +55 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui_uitest.cc View 1 chunk +16 lines, -56 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui_unittest.cc View 1 8 chunks +34 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.h View 2 chunks +12 lines, -9 lines 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.cc View 2 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
All the test changes are to disable the tests on TouchUI. PrintPreviewTabController / browser.cc change ...
9 years, 1 month ago (2011-11-15 11:40:34 UTC) #1
vandebo (ex-Chrome)
9 years, 1 month ago (2011-11-15 21:20:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698