Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: chrome/browser/ui/webui/print_preview_ui_unittest.cc

Issue 8520011: Print Preview: Make print preview tab modal. (try 2) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: disable tests in touch_ui, fix failing test Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/ref_counted_memory.h" 8 #include "base/memory/ref_counted_memory.h"
9 #include "chrome/browser/printing/print_preview_tab_controller.h" 9 #include "chrome/browser/printing/print_preview_tab_controller.h"
10 #include "chrome/browser/ui/browser_list.h" 10 #include "chrome/browser/ui/browser_list.h"
11 #include "chrome/browser/ui/constrained_window_tab_helper.h"
11 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" 12 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
12 #include "chrome/browser/ui/webui/print_preview_ui.h" 13 #include "chrome/browser/ui/webui/print_preview_ui.h"
13 #include "chrome/common/chrome_switches.h" 14 #include "chrome/common/chrome_switches.h"
14 #include "chrome/test/base/browser_with_test_window_test.h" 15 #include "chrome/test/base/browser_with_test_window_test.h"
15 #include "chrome/test/base/testing_profile.h" 16 #include "chrome/test/base/testing_profile.h"
16 #include "content/browser/tab_contents/tab_contents.h" 17 #include "content/browser/tab_contents/tab_contents.h"
17 #include "printing/print_job_constants.h" 18 #include "printing/print_job_constants.h"
18 19
19 namespace { 20 namespace {
20 21
21 const unsigned char blob1[] = 22 const unsigned char blob1[] =
22 "12346102356120394751634516591348710478123649165419234519234512349134"; 23 "12346102356120394751634516591348710478123649165419234519234512349134";
23 24
25 size_t GetConstrainedWindowCount(TabContentsWrapper* tab) {
26 return tab->constrained_window_tab_helper()->constrained_window_count();
27 }
28
24 } // namespace 29 } // namespace
25 30
26 typedef BrowserWithTestWindowTest PrintPreviewUITest; 31 typedef BrowserWithTestWindowTest PrintPreviewUITest;
27 32
33 // Test crashs on TouchUI due to initiator tab's native view having no parent.
34 // http://crbug.com/104284
35 #if defined(TOUCH_UI)
36 #define MAYBE_PrintPreviewData DISABLED_PrintPreviewData
37 #else
38 #define MAYBE_PrintPreviewData PrintPreviewData
39 #endif
28 // Create/Get a preview tab for initiator tab. 40 // Create/Get a preview tab for initiator tab.
29 TEST_F(PrintPreviewUITest, PrintPreviewData) { 41 TEST_F(PrintPreviewUITest, MAYBE_PrintPreviewData) {
30 CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePrintPreview); 42 CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePrintPreview);
31 ASSERT_TRUE(browser()); 43 ASSERT_TRUE(browser());
32 BrowserList::SetLastActive(browser()); 44 BrowserList::SetLastActive(browser());
33 ASSERT_TRUE(BrowserList::GetLastActive()); 45 ASSERT_TRUE(BrowserList::GetLastActive());
34 46
35 browser()->NewTab(); 47 browser()->NewTab();
36 TabContentsWrapper* initiator_tab = 48 TabContentsWrapper* initiator_tab =
37 browser()->GetSelectedTabContentsWrapper(); 49 browser()->GetSelectedTabContentsWrapper();
38 ASSERT_TRUE(initiator_tab); 50 ASSERT_TRUE(initiator_tab);
51 EXPECT_EQ(0U, GetConstrainedWindowCount(initiator_tab));
39 52
40 scoped_refptr<printing::PrintPreviewTabController> 53 scoped_refptr<printing::PrintPreviewTabController>
41 controller(new printing::PrintPreviewTabController()); 54 controller(new printing::PrintPreviewTabController());
42 ASSERT_TRUE(controller); 55 ASSERT_TRUE(controller);
43 56
44 TabContentsWrapper* preview_tab = 57 TabContentsWrapper* preview_tab =
45 controller->GetOrCreatePreviewTab(initiator_tab); 58 controller->GetOrCreatePreviewTab(initiator_tab);
46 59
47 EXPECT_NE(initiator_tab, preview_tab); 60 EXPECT_NE(initiator_tab, preview_tab);
48 EXPECT_EQ(2, browser()->tab_count()); 61 EXPECT_EQ(1, browser()->tab_count());
62 EXPECT_EQ(1U, GetConstrainedWindowCount(initiator_tab));
49 63
50 PrintPreviewUI* preview_ui = 64 PrintPreviewUI* preview_ui =
51 reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui()); 65 reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());
52 ASSERT_TRUE(preview_ui != NULL); 66 ASSERT_TRUE(preview_ui != NULL);
53 67
54 scoped_refptr<RefCountedBytes> data; 68 scoped_refptr<RefCountedBytes> data;
55 preview_ui->GetPrintPreviewDataForIndex( 69 preview_ui->GetPrintPreviewDataForIndex(
56 printing::COMPLETE_PREVIEW_DOCUMENT_INDEX, 70 printing::COMPLETE_PREVIEW_DOCUMENT_INDEX,
57 &data); 71 &data);
58 EXPECT_EQ(NULL, data.get()); 72 EXPECT_EQ(NULL, data.get());
(...skipping 17 matching lines...) Expand all
76 90
77 // Clear the preview data. 91 // Clear the preview data.
78 preview_ui->ClearAllPreviewData(); 92 preview_ui->ClearAllPreviewData();
79 93
80 preview_ui->GetPrintPreviewDataForIndex( 94 preview_ui->GetPrintPreviewDataForIndex(
81 printing::COMPLETE_PREVIEW_DOCUMENT_INDEX, 95 printing::COMPLETE_PREVIEW_DOCUMENT_INDEX,
82 &data); 96 &data);
83 EXPECT_EQ(NULL, data.get()); 97 EXPECT_EQ(NULL, data.get());
84 } 98 }
85 99
100 // http://crbug.com/104284
101 #if defined(TOUCH_UI)
102 #define MAYBE_PrintPreviewDraftPages DISABLED_PrintPreviewDraftPages
103 #else
104 #define MAYBE_PrintPreviewDraftPages PrintPreviewDraftPages
105 #endif
86 // Set and get the individual draft pages. 106 // Set and get the individual draft pages.
87 TEST_F(PrintPreviewUITest, PrintPreviewDraftPages) { 107 TEST_F(PrintPreviewUITest, MAYBE_PrintPreviewDraftPages) {
88 #if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS) 108 #if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS)
89 CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePrintPreview); 109 CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePrintPreview);
90 #endif 110 #endif
91 ASSERT_TRUE(browser()); 111 ASSERT_TRUE(browser());
92 BrowserList::SetLastActive(browser()); 112 BrowserList::SetLastActive(browser());
93 ASSERT_TRUE(BrowserList::GetLastActive()); 113 ASSERT_TRUE(BrowserList::GetLastActive());
94 114
95 browser()->NewTab(); 115 browser()->NewTab();
96 TabContentsWrapper* initiator_tab = 116 TabContentsWrapper* initiator_tab =
97 browser()->GetSelectedTabContentsWrapper(); 117 browser()->GetSelectedTabContentsWrapper();
98 ASSERT_TRUE(initiator_tab); 118 ASSERT_TRUE(initiator_tab);
99 119
100 scoped_refptr<printing::PrintPreviewTabController> 120 scoped_refptr<printing::PrintPreviewTabController>
101 controller(new printing::PrintPreviewTabController()); 121 controller(new printing::PrintPreviewTabController());
102 ASSERT_TRUE(controller); 122 ASSERT_TRUE(controller);
103 123
104 TabContentsWrapper* preview_tab = 124 TabContentsWrapper* preview_tab =
105 controller->GetOrCreatePreviewTab(initiator_tab); 125 controller->GetOrCreatePreviewTab(initiator_tab);
106 126
107 EXPECT_NE(initiator_tab, preview_tab); 127 EXPECT_NE(initiator_tab, preview_tab);
108 EXPECT_EQ(2, browser()->tab_count()); 128 EXPECT_EQ(1, browser()->tab_count());
129 EXPECT_EQ(1U, GetConstrainedWindowCount(initiator_tab));
109 130
110 PrintPreviewUI* preview_ui = 131 PrintPreviewUI* preview_ui =
111 reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui()); 132 reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());
112 ASSERT_TRUE(preview_ui != NULL); 133 ASSERT_TRUE(preview_ui != NULL);
113 134
114 scoped_refptr<RefCountedBytes> data; 135 scoped_refptr<RefCountedBytes> data;
115 preview_ui->GetPrintPreviewDataForIndex(printing::FIRST_PAGE_INDEX, &data); 136 preview_ui->GetPrintPreviewDataForIndex(printing::FIRST_PAGE_INDEX, &data);
116 EXPECT_EQ(NULL, data.get()); 137 EXPECT_EQ(NULL, data.get());
117 138
118 std::vector<unsigned char> preview_data(blob1, blob1 + sizeof(blob1)); 139 std::vector<unsigned char> preview_data(blob1, blob1 + sizeof(blob1));
(...skipping 24 matching lines...) Expand all
143 &data); 164 &data);
144 EXPECT_EQ(dummy_data->size(), data->size()); 165 EXPECT_EQ(dummy_data->size(), data->size());
145 EXPECT_EQ(dummy_data.get(), data.get()); 166 EXPECT_EQ(dummy_data.get(), data.get());
146 167
147 // Clear the preview data. 168 // Clear the preview data.
148 preview_ui->ClearAllPreviewData(); 169 preview_ui->ClearAllPreviewData();
149 preview_ui->GetPrintPreviewDataForIndex(printing::FIRST_PAGE_INDEX, &data); 170 preview_ui->GetPrintPreviewDataForIndex(printing::FIRST_PAGE_INDEX, &data);
150 EXPECT_EQ(NULL, data.get()); 171 EXPECT_EQ(NULL, data.get());
151 } 172 }
152 173
174 // http://crbug.com/104284
175 #if defined(TOUCH_UI)
176 #define MAYBE_GetCurrentPrintPreviewStatus DISABLED_GetCurrentPrintPreviewStatus
177 #else
178 #define MAYBE_GetCurrentPrintPreviewStatus GetCurrentPrintPreviewStatus
179 #endif
153 // Test the browser-side print preview cancellation functionality. 180 // Test the browser-side print preview cancellation functionality.
154 TEST_F(PrintPreviewUITest, GetCurrentPrintPreviewStatus) { 181 TEST_F(PrintPreviewUITest, MAYBE_GetCurrentPrintPreviewStatus) {
155 #if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS) 182 #if !defined(GOOGLE_CHROME_BUILD) || defined(OS_CHROMEOS)
156 CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePrintPreview); 183 CommandLine::ForCurrentProcess()->AppendSwitch(switches::kEnablePrintPreview);
157 #endif 184 #endif
158 ASSERT_TRUE(browser()); 185 ASSERT_TRUE(browser());
159 BrowserList::SetLastActive(browser()); 186 BrowserList::SetLastActive(browser());
160 ASSERT_TRUE(BrowserList::GetLastActive()); 187 ASSERT_TRUE(BrowserList::GetLastActive());
161 188
162 browser()->NewTab(); 189 browser()->NewTab();
163 TabContentsWrapper* initiator_tab = 190 TabContentsWrapper* initiator_tab =
164 browser()->GetSelectedTabContentsWrapper(); 191 browser()->GetSelectedTabContentsWrapper();
165 ASSERT_TRUE(initiator_tab); 192 ASSERT_TRUE(initiator_tab);
166 193
167 scoped_refptr<printing::PrintPreviewTabController> 194 scoped_refptr<printing::PrintPreviewTabController>
168 controller(new printing::PrintPreviewTabController()); 195 controller(new printing::PrintPreviewTabController());
169 ASSERT_TRUE(controller); 196 ASSERT_TRUE(controller);
170 197
171 TabContentsWrapper* preview_tab = 198 TabContentsWrapper* preview_tab =
172 controller->GetOrCreatePreviewTab(initiator_tab); 199 controller->GetOrCreatePreviewTab(initiator_tab);
173 200
174 EXPECT_NE(initiator_tab, preview_tab); 201 EXPECT_NE(initiator_tab, preview_tab);
175 EXPECT_EQ(2, browser()->tab_count()); 202 EXPECT_EQ(1, browser()->tab_count());
203 EXPECT_EQ(1U, GetConstrainedWindowCount(initiator_tab));
176 204
177 PrintPreviewUI* preview_ui = 205 PrintPreviewUI* preview_ui =
178 reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui()); 206 reinterpret_cast<PrintPreviewUI*>(preview_tab->web_ui());
179 ASSERT_TRUE(preview_ui != NULL); 207 ASSERT_TRUE(preview_ui != NULL);
180 208
181 // Test with invalid |preview_ui_addr|. 209 // Test with invalid |preview_ui_addr|.
182 bool cancel = false; 210 bool cancel = false;
183 preview_ui->GetCurrentPrintPreviewStatus("invalid", 0, &cancel); 211 preview_ui->GetCurrentPrintPreviewStatus("invalid", 0, &cancel);
184 EXPECT_TRUE(cancel); 212 EXPECT_TRUE(cancel);
185 213
(...skipping 18 matching lines...) Expand all
204 cancel = false; 232 cancel = false;
205 preview_ui->GetCurrentPrintPreviewStatus(preview_ui_addr, kFirstRequestId, 233 preview_ui->GetCurrentPrintPreviewStatus(preview_ui_addr, kFirstRequestId,
206 &cancel); 234 &cancel);
207 EXPECT_TRUE(cancel); 235 EXPECT_TRUE(cancel);
208 236
209 cancel = true; 237 cancel = true;
210 preview_ui->GetCurrentPrintPreviewStatus(preview_ui_addr, kSecondRequestId, 238 preview_ui->GetCurrentPrintPreviewStatus(preview_ui_addr, kSecondRequestId,
211 &cancel); 239 &cancel);
212 EXPECT_FALSE(cancel); 240 EXPECT_FALSE(cancel);
213 } 241 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698