Issue 8518001: Make eval compilation cache calling scope sensitive.

Issue 8518001: Make eval compilation cache calling scope sensitive. (Closed)

Created:
9 years, 1 month ago by Steven

Modified:
9 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make eval compilation cache calling scope sensitive. Committed: http://code.google.com/p/v8/source/detail?r=9984

Patch Set 1 #

Total comments: 10

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -57 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/compilation-cache.h	View	4 chunks	+25 lines, -7 lines	2 comments	Download
M	src/compilation-cache.cc	View	7 chunks	+27 lines, -15 lines	2 comments	Download
M	src/compiler.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler.cc	View	3 chunks	+6 lines, -4 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/objects.h	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/objects.cc	View	6 chunks	+28 lines, -13 lines	6 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.cc	View	7 chunks	+17 lines, -10 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.cc File src/compilation-cache.cc (right): http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.cc#newcode1 src/compilation-cache.cc:1: // Copyright 2008 the V8 project ...

9 years, 1 month ago (2011-11-10 11:53:23 UTC) #2

Steven

9 years, 1 month ago (2011-11-14 08:57:20 UTC) #3

http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.cc
File src/compilation-cache.cc (right):

http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.cc#newcode1
src/compilation-cache.cc:1: // Copyright 2008 the V8 project authors. All rights
reserved.
On 2011/11/10 11:53:23, Jakob wrote:
> 2011

Done.

http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.h
File src/compilation-cache.h (right):

http://codereview.chromium.org/8518001/diff/1/src/compilation-cache.h#newcode1
src/compilation-cache.h:1: // Copyright 2008 the V8 project authors. All rights
reserved.
On 2011/11/10 11:53:23, Jakob wrote:
> 2011

Done.

http://codereview.chromium.org/8518001/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/8518001/diff/1/src/objects.cc#newcode10303
src/objects.cc:10303: FixedArray* pair = FixedArray::cast(other);
On 2011/11/10 11:53:23, Jakob wrote:
> Please rename this. If it has 4 elements, it's not a pair. Maybe "array" or
> "other_array"?

Done.

http://codereview.chromium.org/8518001/diff/1/src/objects.cc#newcode10342
src/objects.cc:10342: FixedArray* pair = FixedArray::cast(obj);
On 2011/11/10 11:53:23, Jakob wrote:
> Same here

Done.

http://codereview.chromium.org/8518001/diff/1/src/objects.cc#newcode10358
src/objects.cc:10358: FixedArray* pair = FixedArray::cast(obj);
On 2011/11/10 11:53:23, Jakob wrote:
> And here.

Done.

Expand Messages | Collapse Messages