src/ia32/full-codegen-ia32.cc - Issue 8518001: Make eval compilation cache calling scope sensitive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 8518001: Make eval compilation cache calling scope sensitive. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/full-codegen-ia32.cc

diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc

index bd5df170caab963ab012259537454a0bdca329c2..d538f83b851299b587f8813f23b7c374947c8922 100644

--- a/src/ia32/full-codegen-ia32.cc

+++ b/src/ia32/full-codegen-ia32.cc

@@ -2150,7 +2150,10 @@ void FullCodeGenerator::EmitResolvePossiblyDirectEval(int arg_count) {

FLAG_harmony_scoping ? kStrictMode : strict_mode_flag();

__ push(Immediate(Smi::FromInt(strict_mode)));

- __ CallRuntime(Runtime::kResolvePossiblyDirectEval, 4);

+ // Push the start position of the scope the calls resides in.

+ __ push(Immediate(Smi::FromInt(scope()->start_position())));

+ __ CallRuntime(Runtime::kResolvePossiblyDirectEval, 5);

}