Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(511)

Issue 8515026: Add SSLSocket interface. (Closed)

Created:
9 years, 1 month ago by Sergey Ulanov
Modified:
9 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Wez, wtc
Visibility:
Public.

Description

Add SSLSocket interface. The new interface defines functionality common between SSLClientSocket and SSLServerSocket. TEST=None BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110025

Patch Set 1 #

Total comments: 1

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -26 lines) Patch
M net/net.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M net/socket/ssl_client_socket.h View 1 4 chunks +5 lines, -13 lines 0 comments Download
M net/socket/ssl_server_socket.h View 1 3 chunks +2 lines, -13 lines 0 comments Download
A net/socket/ssl_socket.h View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Sergey Ulanov
9 years, 1 month ago (2011-11-11 01:06:25 UTC) #1
Sergey Ulanov
wtc: ping
9 years, 1 month ago (2011-11-11 23:40:54 UTC) #2
Sergey Ulanov
+willchan. Will, can you please take a look while Wan-Teh is ooo?
9 years, 1 month ago (2011-11-14 20:39:10 UTC) #3
wtc
LGTM. http://codereview.chromium.org/8515026/diff/1/net/socket/ssl_socket.h File net/socket/ssl_socket.h (right): http://codereview.chromium.org/8515026/diff/1/net/socket/ssl_socket.h#newcode26 net/socket/ssl_socket.h:26: virtual int ExportKeyingMaterial(const base::StringPiece& label, Is this the ...
9 years, 1 month ago (2011-11-15 01:24:00 UTC) #4
Sergey Ulanov
On 2011/11/15 01:24:00, wtc wrote: > LGTM. > > http://codereview.chromium.org/8515026/diff/1/net/socket/ssl_socket.h > File net/socket/ssl_socket.h (right): > ...
9 years, 1 month ago (2011-11-15 01:38:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8515026/5002
9 years, 1 month ago (2011-11-15 01:40:07 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-15 03:12:34 UTC) #7
Change committed as 110025

Powered by Google App Engine
This is Rietveld 408576698