Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: net/socket/ssl_client_socket.h

Issue 8515026: Add SSLSocket interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: - Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/net.gyp ('k') | net/socket/ssl_server_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/ssl_client_socket.h
diff --git a/net/socket/ssl_client_socket.h b/net/socket/ssl_client_socket.h
index 104cca3407838675efb392fa189600cd764afcc1..ca4393b1e1949e580d40bfe823c901611676a822 100644
--- a/net/socket/ssl_client_socket.h
+++ b/net/socket/ssl_client_socket.h
@@ -11,12 +11,9 @@
#include "net/base/completion_callback.h"
#include "net/base/load_flags.h"
#include "net/base/net_errors.h"
+#include "net/socket/ssl_socket.h"
#include "net/socket/stream_socket.h"
-namespace base {
-class StringPiece;
-} // namespace base
-
namespace net {
class CertVerifier;
@@ -79,7 +76,7 @@ struct SSLClientSocketContext {
// connection is established. If a SSL error occurs during the handshake,
// Connect will fail.
//
-class NET_EXPORT SSLClientSocket : public StreamSocket {
+class NET_EXPORT SSLClientSocket : public SSLSocket {
public:
SSLClientSocket();
@@ -107,6 +104,9 @@ class NET_EXPORT SSLClientSocket : public StreamSocket {
};
// Gets the SSL connection information of the socket.
+ //
+ // TODO(sergeyu): Move this method to the SSLSocket interface and
+ // implemented in SSLServerSocket too.
virtual void GetSSLInfo(SSLInfo* ssl_info) = 0;
// Gets the SSL CertificateRequest info of the socket after Connect failed
@@ -114,14 +114,6 @@ class NET_EXPORT SSLClientSocket : public StreamSocket {
virtual void GetSSLCertRequestInfo(
SSLCertRequestInfo* cert_request_info) = 0;
- // Exports data derived from the SSL master-secret (see RFC 5705).
- // The call will fail with an error if the socket is not connected, or the
- // SSL implementation does not support the operation.
- virtual int ExportKeyingMaterial(const base::StringPiece& label,
- const base::StringPiece& context,
- unsigned char *out,
- unsigned int outlen) = 0;
-
// Get the application level protocol that we negotiated with the server.
// *proto is set to the resulting protocol (n.b. that the string may have
// embedded NULs).
« no previous file with comments | « net/net.gyp ('k') | net/socket/ssl_server_socket.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698