Chromium Code Reviews| Index: tools/testing/dart/test_runner.dart |
| diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart |
| index 0e4c13b3d3a4ad809cd844aca1c82a71e6937f18..d17ffbbc008c0ede362ff3655657bce40c33d49d 100644 |
| --- a/tools/testing/dart/test_runner.dart |
| +++ b/tools/testing/dart/test_runner.dart |
| @@ -15,14 +15,6 @@ |
| * - Evaluating the output of each test as pass/fail/crash/timeout. |
| */ |
| -// Possible outcomes of running a test. |
| -final CRASH = "Crash"; |
| -final TIMEOUT = "Timeout"; |
| -final FAIL = "Fail"; |
| -final PASS = "Pass"; |
| -// An indication to skip the test. The caller is responsible for skipping it. |
| -final SKIP = "Skip"; |
| - |
| final int NO_TIMEOUT = 0; |
| String getDartShellFileName() { |
| @@ -58,7 +50,7 @@ class TestCase { |
| } |
| } |
| - bool get isNegative() => false; |
| + bool get isNegative() => displayName.contains("NegativeTest"); |
| void completed() { completedHandler(this); } |
| } |
| @@ -84,7 +76,7 @@ class TestOutput { |
| bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result); |
| - bool get hasCrashed() => !timedOut && exitCode != -1 && exitCode != 0; |
| + bool get hasCrashed() => !timedOut && exitCode != 255 && exitCode != 0; |
|
Mads Ager (google)
2011/11/10 16:31:57
This looks accidental?
Bill Hesse
2011/11/10 16:44:45
No, the processes are returning 255 for uncaught e
Bill Hesse
2011/11/14 10:08:05
OK, this has been fixed, so failures return -1, so
|
| bool get hasTimedOut() => timedOut; |