Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 8514003: tools/test.dart: Read test expectations from the status file, and pass them to the test runner. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Import library with PASS, FAIL, CRASH to TestRunnerTest Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index 0e4c13b3d3a4ad809cd844aca1c82a71e6937f18..d17ffbbc008c0ede362ff3655657bce40c33d49d 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -15,14 +15,6 @@
* - Evaluating the output of each test as pass/fail/crash/timeout.
*/
-// Possible outcomes of running a test.
-final CRASH = "Crash";
-final TIMEOUT = "Timeout";
-final FAIL = "Fail";
-final PASS = "Pass";
-// An indication to skip the test. The caller is responsible for skipping it.
-final SKIP = "Skip";
-
final int NO_TIMEOUT = 0;
String getDartShellFileName() {
@@ -58,7 +50,7 @@ class TestCase {
}
}
- bool get isNegative() => false;
+ bool get isNegative() => displayName.contains("NegativeTest");
void completed() { completedHandler(this); }
}
@@ -84,7 +76,7 @@ class TestOutput {
bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
- bool get hasCrashed() => !timedOut && exitCode != -1 && exitCode != 0;
+ bool get hasCrashed() => !timedOut && exitCode != 255 && exitCode != 0;
Mads Ager (google) 2011/11/10 16:31:57 This looks accidental?
Bill Hesse 2011/11/10 16:44:45 No, the processes are returning 255 for uncaught e
Bill Hesse 2011/11/14 10:08:05 OK, this has been fixed, so failures return -1, so
bool get hasTimedOut() => timedOut;
« tools/testing/dart/status_file_parser.dart ('K') | « tools/testing/dart/status_file_parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698