tools/test.dart: Read test expectations from the status file, and pass them to the test runner.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library("test_runner");
 
 
 #import("status_file_parser.dart");
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
  */
 
-// Possible outcomes of running a test.
-final CRASH = "Crash";
-final TIMEOUT = "Timeout";
-final FAIL = "Fail";
-final PASS = "Pass";
-// An indication to skip the test.  The caller is responsible for skipping it.
-final SKIP = "Skip";
-
 final int NO_TIMEOUT = 0;
 
 String getDartShellFileName() {
   var names = ["out/Debug_ia32/dart_bin",
                "out/Release_ia32/dart_bin",
                "xcodebuild/Debug_ia32/dart_bin",
                "xcodebuild/Release_ia32/dart_bin",
                "Debug_ia32/dart_bin.exe",
                "Release_ia32/dart_bin.exe"];
   for (var name in names) {
@@ skipping 15 matching lines @@
   Function completedHandler;
 
   TestCase(this.displayName, this.executablePath, this.arguments,
            this.completedHandler, this.expectedOutcomes) {
     commandLine = executablePath;
     for (var arg in arguments) {
       commandLine += " " + arg;
     }
   }
 
-  bool get isNegative() => false;
+  bool get isNegative() => displayName.contains("NegativeTest");
 
   void completed() { completedHandler(this); }    
 }
 
 
 class TestOutput {
   // The TestCase this is the output from.
   TestCase testCase;
   int exitCode;
   bool timedOut;
   bool failed = false;
   List<String> stdout;
   List<String> stderr;
   Duration time;
   
   TestOutput(this.testCase, this.exitCode, this.timedOut, this.stdout,
              this.stderr, this.time) {
     testCase.output = this;
   }
 
   String get result() =>
       hasCrashed ? CRASH : (hasTimedOut ? TIMEOUT : (hasFailed ? FAIL : PASS));
 
   bool get unexpectedOutput() => !testCase.expectedOutcomes.contains(result);
   
-  bool get hasCrashed() => !timedOut && exitCode != -1 && exitCode != 0;
+  bool get hasCrashed() => !timedOut && exitCode != 255 && exitCode != 0;

[Mads Ager (google), 2011/11/10 16:31:57]

This looks accidental?

[Bill Hesse, 2011/11/10 16:44:45]

No, the processes are returning 255 for uncaught exceptions.
So 255 is a fail, not a crash.

[Bill Hesse, 2011/11/14 10:08:05]

OK, this has been fixed, so failures return -1, so will remove.

On 2011/11/10 16:44:45, Bill Hesse wrote:

 
   bool get hasTimedOut() => timedOut;
 
   bool get didFail() => exitCode != 0 && !hasCrashed;
 
   // Reverse result of a negative test.
   bool get hasFailed() => (testCase.isNegative ? !didFail : didFail);
 }
 
 
@@ skipping 84 matching lines @@
       new RunningProcess(test, 60).start();
       numProcesses++;
     }
   }
 
   runTest(TestCase test) {
     tests.add(test);
     tryRunTest();
   }
 }