Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 8513017: Add GL_ANGLE_pack_reverse_row_order to command buffer (Closed)

Created:
9 years, 1 month ago by bsalomon
Modified:
9 years ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Add GL_ANGLE_pack_reverse_row_order to command buffer Bug=82559 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112245

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : '' #

Patch Set 6 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -6 lines) Patch
M gpu/command_buffer/client/gles2_implementation.h View 1 2 3 4 5 4 chunks +15 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 3 4 5 7 chunks +64 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_utils.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 1 chunk +12 lines, -3 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 2 3 4 5 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
greggman
as for looking it up on the client side, yes, you'll need to call getString ...
9 years, 1 month ago (2011-11-17 19:56:54 UTC) #1
bsalomon
PTAL. The latest patchset determines whether the extension is available on the client side using ...
9 years ago (2011-11-28 14:00:40 UTC) #2
greggman
9 years ago (2011-11-29 21:32:27 UTC) #3
lgtm

http://codereview.chromium.org/8513017/diff/18001/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/8513017/diff/18001/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:5719: if
(GL_PACK_REVERSE_ROW_ORDER_ANGLE != pname &&
this might be more future proof as a switch?

Powered by Google App Engine
This is Rietveld 408576698