Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 8512004: Fixing generated hash function on all platforms. (Closed)

Created:
9 years, 1 month ago by Yang
Modified:
9 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fixing generated hash function on all platforms. BUG=v8:1808 TEST=cctest/test-hashing.cc Committed: http://code.google.com/p/v8/source/detail?r=9956

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -155 lines) Patch
M src/arm/code-stubs-arm.h View 1 chunk +64 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 7 chunks +12 lines, -74 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 7 chunks +9 lines, -6 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +64 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 4 chunks +7 lines, -67 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 7 chunks +14 lines, -6 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-hashing.cc View 1 chunk +158 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
This fixes several problems at once: In StringHelper::GenerateHash* 1) Runtime hashing uses logical right shifts, ...
9 years, 1 month ago (2011-11-10 13:52:38 UTC) #1
Sven Panne
9 years, 1 month ago (2011-11-10 14:24:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698