Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 8511077: Fixed css to make host list prettier. (Closed)

Created:
9 years, 1 month ago by Jamie
Modified:
9 years, 1 month ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fixed css to make host list prettier. BUG=None TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109968

Patch Set 1 #

Total comments: 6

Patch Set 2 : Removed accidental script tag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -16 lines) Patch
M remoting/remoting.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A remoting/resources/icon_host.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/webapp/me2mom/_locales/en/messages.json View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/webapp/me2mom/choice.css View 4 chunks +56 lines, -1 line 0 comments Download
M remoting/webapp/me2mom/choice.html View 1 1 chunk +5 lines, -5 lines 0 comments Download
M remoting/webapp/me2mom/client_screen.js View 4 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jamie
PTAL.
9 years, 1 month ago (2011-11-12 00:11:50 UTC) #1
Wez
http://codereview.chromium.org/8511077/diff/1/remoting/webapp/me2mom/_locales/en/messages.json File remoting/webapp/me2mom/_locales/en/messages.json (right): http://codereview.chromium.org/8511077/diff/1/remoting/webapp/me2mom/_locales/en/messages.json#newcode123 remoting/webapp/me2mom/_locales/en/messages.json:123: "message": "My Computers", "My Computers"...? Are you sure? http://codereview.chromium.org/8511077/diff/1/remoting/webapp/me2mom/choice.html ...
9 years, 1 month ago (2011-11-12 01:12:42 UTC) #2
Jamie
http://codereview.chromium.org/8511077/diff/1/remoting/webapp/me2mom/_locales/en/messages.json File remoting/webapp/me2mom/_locales/en/messages.json (right): http://codereview.chromium.org/8511077/diff/1/remoting/webapp/me2mom/_locales/en/messages.json#newcode123 remoting/webapp/me2mom/_locales/en/messages.json:123: "message": "My Computers", On 2011/11/12 01:12:42, Wez wrote: > ...
9 years, 1 month ago (2011-11-14 18:28:15 UTC) #3
Wez
9 years, 1 month ago (2011-11-14 18:31:59 UTC) #4
LGTM

Moving from debug log to console log sounds reasonable for a follow-up CL; would
make the stats bar smaller => more useful.

Powered by Google App Engine
This is Rietveld 408576698