Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8511075: Move the struct used when showing a desktop notification to content/public/common, so that chrome... (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
Reviewers:
tburkard
CC:
chromium-reviews, jennb, nkostylev+watch_chromium.org, prasadt, jam, Dmitry Titov, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, jianli, Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move the struct used when showing a desktop notification to content/public/common, so that chrome code doesn't include desktop_notification_messages.h which is an internal detail of content. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109757

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -78 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/notifications/desktop_notifications_unittest.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/notifications/desktop_notifications_unittest.cc View 1 8 chunks +14 lines, -9 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/desktop_notifications_unittest.cc View 13 chunks +23 lines, -14 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/mock_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.h View 3 chunks +8 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/desktop_notification_messages.h View 2 chunks +13 lines, -28 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
A content/public/common/show_desktop_notification_params.h View 1 1 chunk +46 lines, -0 lines 0 comments Download
A content/public/common/show_desktop_notification_params.cc View 1 1 chunk +16 lines, -0 lines 0 comments Download
M content/renderer/notification_provider.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
9 years, 1 month ago (2011-11-11 23:53:02 UTC) #1
tburkard
9 years, 1 month ago (2011-11-11 23:55:44 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698