chrome/browser/notifications/desktop_notification_service.cc - Issue 8511075: Move the struct used when showing a desktop notification to content/public/common, so that chrome...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/desktop_notification_service.cc

Issue 8511075: Move the struct used when showing a desktop notification to content/public/common, so that chrome... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/desktop_notification_service.h ('k') | chrome/browser/notifications/desktop_notifications_unittest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/desktop_notification_service.cc

===================================================================

--- chrome/browser/notifications/desktop_notification_service.cc (revision 109661)

+++ chrome/browser/notifications/desktop_notification_service.cc (working copy)

@@ -31,9 +31,9 @@

#include "content/browser/renderer_host/render_view_host.h"

#include "content/browser/site_instance.h"

#include "content/browser/worker_host/worker_process_host.h"

-#include "content/common/desktop_notification_messages.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/notification_service.h"

+#include "content/public/common/show_desktop_notification_params.h"

#include "grit/browser_resources.h"

#include "grit/chromium_strings.h"

#include "grit/generated_resources.h"

@@ -386,7 +386,7 @@

}

bool DesktopNotificationService::ShowDesktopNotification(

- const DesktopNotificationHostMsg_Show_Params& params,

+ const content::ShowDesktopNotificationHostMsgParams& params,

int process_id, int route_id, DesktopNotificationSource source) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

const GURL& origin = params.origin;