Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8511032: Make the Pepper Flash net address just private, not Flash-specific. (Closed)

Created:
9 years, 1 month ago by viettrungluu
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jam, yzshen+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Make the Pepper Flash net address just private, not Flash-specific. Note that, though the PP_Flash_NetAddress struct is being renamed, binary compatibility is being maintained. It's also safe to just rename the PPB_Flash_NetAddress interface without maintaining backwards compatibility since Pepper Flash isn't using it yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109335

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -783 lines) Patch
M content/browser/renderer_host/pepper_message_filter.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper_message_filter.cc View 23 chunks +44 lines, -43 lines 0 comments Download
M content/common/pepper_messages.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/pepper_plugin_delegate_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D ppapi/api/private/ppb_flash_net_address.idl View 1 chunk +0 lines, -61 lines 0 comments Download
D ppapi/api/private/ppb_flash_net_connector.idl View 1 chunk +0 lines, -41 lines 0 comments Download
M ppapi/api/private/ppb_flash_tcp_socket.idl View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/api/private/ppb_flash_udp_socket.idl View 3 chunks +3 lines, -4 lines 0 comments Download
A + ppapi/api/private/ppb_net_address_private.idl View 3 chunks +12 lines, -12 lines 0 comments Download
D ppapi/c/private/ppb_flash_net_address.h View 1 chunk +0 lines, -85 lines 0 comments Download
M ppapi/c/private/ppb_flash_net_connector.h View 2 chunks +8 lines, -6 lines 0 comments Download
M ppapi/c/private/ppb_flash_tcp_socket.h View 3 chunks +5 lines, -5 lines 0 comments Download
M ppapi/c/private/ppb_flash_udp_socket.h View 5 chunks +5 lines, -5 lines 0 comments Download
A + ppapi/c/private/ppb_net_address_private.h View 4 chunks +19 lines, -19 lines 0 comments Download
D ppapi/cpp/private/flash_net_address.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ppapi/cpp/private/flash_net_address.cc View 1 chunk +0 lines, -81 lines 0 comments Download
M ppapi/cpp/private/flash_net_connector.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/cpp/private/flash_net_connector.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/cpp/private/flash_tcp_socket.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/cpp/private/flash_tcp_socket.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/cpp/private/flash_udp_socket.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/cpp/private/flash_udp_socket.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A ppapi/cpp/private/net_address_private.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ppapi/cpp/private/net_address_private.cc View 1 chunk +77 lines, -0 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 4 chunks +6 lines, -6 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/ppapi_param_traits.cc View 2 chunks +9 lines, -8 lines 0 comments Download
M ppapi/proxy/ppb_flash_net_connector_proxy.cc View 8 chunks +21 lines, -21 lines 0 comments Download
M ppapi/proxy/ppb_flash_tcp_socket_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_flash_tcp_socket_proxy.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M ppapi/proxy/ppb_flash_udp_socket_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_flash_udp_socket_proxy.cc View 9 chunks +10 lines, -11 lines 0 comments Download
D ppapi/shared_impl/private/flash_net_address_impl.h View 1 chunk +0 lines, -25 lines 0 comments Download
D ppapi/shared_impl/private/flash_net_address_impl.cc View 1 chunk +0 lines, -175 lines 0 comments Download
A ppapi/shared_impl/private/net_address_private_impl.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + ppapi/shared_impl/private/net_address_private_impl.cc View 9 chunks +22 lines, -20 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 chunk +2 lines, -1 line 3 comments Download
M ppapi/thunk/ppb_flash_net_connector_api.h View 1 chunk +5 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_flash_net_connector_thunk.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_flash_tcp_socket_api.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_flash_tcp_socket_thunk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_flash_udp_socket_api.h View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/thunk/ppb_flash_udp_socket_thunk.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.h View 2 chunks +3 lines, -1 line 0 comments Download
M webkit/plugins/ppapi/mock_plugin_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/plugin_delegate.h View 3 chunks +3 lines, -5 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_net_connector_impl.h View 2 chunks +9 lines, -9 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_net_connector_impl.cc View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
yzshen -> review dmichael -> OWNERS approval for the general rename (I'll add tests soon, ...
9 years, 1 month ago (2011-11-09 22:10:30 UTC) #1
yzshen1
lgtm http://codereview.chromium.org/8511032/diff/1/ppapi/thunk/interfaces_ppb_private.h File ppapi/thunk/interfaces_ppb_private.h (right): http://codereview.chromium.org/8511032/diff/1/ppapi/thunk/interfaces_ppb_private.h#newcode14 ppapi/thunk/interfaces_ppb_private.h:14: PROXIED_IFACE(NoAPIName, PPB_NETADDRESS_PRIVATE_INTERFACE, nit: sort the list, please.
9 years, 1 month ago (2011-11-09 22:46:45 UTC) #2
dmichael (off chromium)
owners' lgtm
9 years, 1 month ago (2011-11-09 22:49:00 UTC) #3
viettrungluu
http://codereview.chromium.org/8511032/diff/1/ppapi/thunk/interfaces_ppb_private.h File ppapi/thunk/interfaces_ppb_private.h (right): http://codereview.chromium.org/8511032/diff/1/ppapi/thunk/interfaces_ppb_private.h#newcode14 ppapi/thunk/interfaces_ppb_private.h:14: PROXIED_IFACE(NoAPIName, PPB_NETADDRESS_PRIVATE_INTERFACE, On 2011/11/09 22:46:45, yzshen1 wrote: > nit: ...
9 years, 1 month ago (2011-11-09 23:06:15 UTC) #4
yzshen1
9 years, 1 month ago (2011-11-09 23:07:53 UTC) #5 
http://codereview.chromium.org/8511032/diff/1/ppapi/thunk/interfaces_ppb_priv...
File ppapi/thunk/interfaces_ppb_private.h (right):

http://codereview.chromium.org/8511032/diff/1/ppapi/thunk/interfaces_ppb_priv...
ppapi/thunk/interfaces_ppb_private.h:14: PROXIED_IFACE(NoAPIName,
PPB_NETADDRESS_PRIVATE_INTERFACE,
Okay.
On 2011/11/09 23:06:15, viettrungluu wrote:
> On 2011/11/09 22:46:45, yzshen1 wrote:
> > nit: sort the list, please.
> 
> I'm assuming that we're keeping the fullscreen one at the bottom, since it's
to
> be removed.

Powered by Google App Engine
This is Rietveld 408576698