Add status area to Aura builds.

Add status area to Aura builds.

BUG=97263
TEST=Test status area buttons and associated menus in aura + win / linux / chromeos. (Only the clock and --memory-widget icon will show up on non-chromeos)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109841

[stevenjb, 2011-11-10 00:52:29]

Much simpler CL for adding the status area to Aura.
(A couple of re-factoring CLs made this one much smaller now).

[sky, 2011-11-10 01:39:23]

Since Dave has been reviewing this, I'm going to let him continue reviewing it.

  -Scott

On Wed, Nov 9, 2011 at 4:52 PM,  <stevenjb@chromium.org> wrote:
> Reviewers: sky, DaveMoore,
>
> Message:
> Much simpler CL for adding the status area to Aura.
> (A couple of re-factoring CLs made this one much smaller now).
>
>
> Description:
> Add status area to Aura builds.
>
> BUG=97263
> TEST=Test status area buttons and associated menus in aura + win / linux /
> chromeos. (Only the clock and --memory-widget icon will show up on
> non-chromeos)
>
>
> Please review this at http://codereview.chromium.org/8509027/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/app/generated_resources.grd
>  M chrome/browser/chrome_browser_parts_aura.cc
>  M chrome/browser/chromeos/frame/browser_view.cc
>  M chrome/browser/chromeos/login/background_view.cc
>  M chrome/browser/chromeos/login/webui_login_view.cc
>  M chrome/browser/chromeos/status/clock_menu_button.h
>  M chrome/browser/chromeos/status/clock_menu_button.cc
>  M chrome/browser/chromeos/status/input_method_menu_button.cc
>  M chrome/browser/chromeos/status/memory_menu_button.h
>  M chrome/browser/chromeos/status/memory_menu_button.cc
>  M chrome/browser/chromeos/status/network_menu.cc
>  M chrome/browser/chromeos/status/network_menu_button.cc
>  M chrome/browser/chromeos/status/status_area_button.h
>  M chrome/browser/chromeos/status/status_area_view.cc
>  M chrome/browser/chromeos/status/status_area_view_chromeos.h
>  M chrome/browser/chromeos/view_ids.h
>  M chrome/browser/renderer_host/chrome_render_message_filter.cc
>  M chrome/browser/ui/view_ids.h
>  M chrome/browser/ui/views/aura/chrome_shell_delegate.h
>  M chrome/browser/ui/views/aura/chrome_shell_delegate.cc
>  A chrome/browser/ui/views/aura/status_area_host_aura.h
>  A chrome/browser/ui/views/aura/status_area_host_aura.cc
>  M chrome/chrome_browser.gypi
>  M chrome/common/chrome_switches.h
>  M chrome/common/chrome_switches.cc
>  M ui/aura_shell/examples/aura_shell_main.cc
>  M ui/aura_shell/shell.h
>  M ui/aura_shell/shell.cc
>  M ui/aura_shell/shell_delegate.h
>
>
>

[DaveMoore, 2011-11-10 02:05:46]

lgtm modulo comments below

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/chromeos/stat...
File chrome/browser/chromeos/status/clock_menu_button.cc (right):

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/chromeos/stat...
chrome/browser/chromeos/status/clock_menu_button.cc:45: #if defined(OS_CHROMEOS)
Whenever we have a #if defined(OS_CHROMEOS) in a file that has chromeos in the
path we should include an explaination.

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/renderer_host...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_render_message_filter.cc:376:
base::ThreadRestrictions::ScopedAllowIO allow_io;
Should this be here (or in a separate cl)?

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/ui/views/aura...
File chrome/browser/ui/views/aura/status_area_host_aura.h (right):

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/ui/views/aura...
chrome/browser/ui/views/aura/status_area_host_aura.h:31: virtual void
ExecuteStatusAreaCommand(
No blank lines between decls

http://codereview.chromium.org/8509027/diff/2001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/8509027/diff/2001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:4154: # Always include status area code for aura
builds.
I understand that we want to share this between chromeos and aura for now, with
eventually making the chromeos build imply aura, but this is strange and should
be commented more explicitly.

[Nikita (slow), 2011-11-10 08:38:53]

When switching from login screen into user session, StatusArea is recreated with
the different host and screen_mode?

[stevenjb, 2011-11-10 19:57:52]

StatusAreaViewChromeos is created and owned by WebUILoginView and
chromeos::BrowserView respectively; it is not passed from one to the other.

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/chromeos/stat...
File chrome/browser/chromeos/status/clock_menu_button.cc (right):

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/chromeos/stat...
chrome/browser/chromeos/status/clock_menu_button.cc:45: #if defined(OS_CHROMEOS)
On 2011/11/10 02:05:46, DaveMoore wrote:
> Whenever we have a #if defined(OS_CHROMEOS) in a file that has chromeos in the
> path we should include an explaination.

Done.

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/renderer_host...
File chrome/browser/renderer_host/chrome_render_message_filter.cc (right):

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/renderer_host...
chrome/browser/renderer_host/chrome_render_message_filter.cc:376:
base::ThreadRestrictions::ScopedAllowIO allow_io;
On 2011/11/10 02:05:46, DaveMoore wrote:
> Should this be here (or in a separate cl)?

Will separate.

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/ui/views/aura...
File chrome/browser/ui/views/aura/status_area_host_aura.h (right):

http://codereview.chromium.org/8509027/diff/2001/chrome/browser/ui/views/aura...
chrome/browser/ui/views/aura/status_area_host_aura.h:31: virtual void
ExecuteStatusAreaCommand(
On 2011/11/10 02:05:46, DaveMoore wrote:
> No blank lines between decls

Done.

http://codereview.chromium.org/8509027/diff/2001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/8509027/diff/2001/chrome/chrome_browser.gypi#n...
chrome/chrome_browser.gypi:4154: # Always include status area code for aura
builds.
On 2011/11/10 02:05:46, DaveMoore wrote:
> I understand that we want to share this between chromeos and aura for now,
with
> eventually making the chromeos build imply aura, but this is strange and
should
> be commented more explicitly.

Done.