Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8508055: Move views::Accelerator to ui in order to use it from aura code. (Closed)

Created:
9 years, 1 month ago by mazda
Modified:
9 years, 1 month ago
CC:
chromium-reviews, msw+watch_chromium.org, tfarina, dcheng, Paweł Hajdan Jr., alicet1, dhollowa
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Move views::Accelerator to ui in order to use it from aura code. This is the first preliminary change for the support of global keyboard shortcut. BUG=97255 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109872

Patch Set 1 #

Total comments: 2

Patch Set 2 : Delete views/accelerator.{cc,h} #

Patch Set 3 : '' #

Patch Set 4 : Fix linux_chromeos build #

Patch Set 5 : Fix linux_view build #

Patch Set 6 : Rebase #

Patch Set 7 : '' #

Patch Set 8 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -512 lines) Patch
M chrome/browser/chromeos/frame/browser_view.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screen_locker_views.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/screen_locker_views.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
chrome/browser/chromeos/login/wizard_accessibility_helper.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_helper.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/external_tab_container_win.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/external_tab_container_win.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/avatar_menu_bubble_view.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/bubble/bubble.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.h View 1 2 3 4 5 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/views/critical_notification_bubble_view.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 4 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 8 chunks +18 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/html_dialog_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/html_dialog_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/js_modal_dialog_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_dialog_view.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_dialog_view.cc View 1 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/unhandled_keyboard_event_handler.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ui/base/models/accelerator.h View 1 4 chunks +46 lines, -0 lines 0 comments Download
A + ui/base/models/accelerator.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/window/dialog_client_view.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 2 3 4 5 5 chunks +7 lines, -7 lines 0 comments Download
M views/accelerator.h View 1 1 chunk +0 lines, -73 lines 0 comments Download
D views/accelerator.cc View 1 1 chunk +0 lines, -163 lines 0 comments Download
M views/accessible_pane_view.h View 1 3 chunks +7 lines, -6 lines 0 comments Download
M views/accessible_pane_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/accessible_pane_view_unittest.cc View 1 2 chunks +6 lines, -5 lines 0 comments Download
M views/bubble/bubble_delegate.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M views/bubble/bubble_delegate.cc View 1 2 3 4 5 3 chunks +4 lines, -3 lines 0 comments Download
M views/controls/button/custom_button.h View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/custom_button.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/button/text_button.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M views/controls/combobox/native_combobox_views.h View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/combobox/native_combobox_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu.h View 1 2 chunks +5 lines, -3 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_delegate.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M views/controls/menu/menu_delegate.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_item_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_model_adapter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_model_adapter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/native_menu_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/native_menu_views.h View 1 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/native_menu_views.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/native_menu_win.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/message_box_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/message_box_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/tabbed_pane/tabbed_pane.h View 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/tabbed_pane/tabbed_pane.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/textfield/native_textfield_win.cc View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M views/controls/tree/tree_view.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M views/focus/accelerator_handler_gtk.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M views/focus/accelerator_handler_gtk_unittest.cc View 1 2 3 4 5 6 7 5 chunks +6 lines, -5 lines 0 comments Download
M views/focus/accelerator_handler_touch.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M views/focus/accelerator_handler_wayland.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M views/focus/focus_manager.h View 1 5 chunks +13 lines, -11 lines 0 comments Download
M views/focus/focus_manager.cc View 1 6 chunks +13 lines, -13 lines 0 comments Download
M views/focus/focus_manager_unittest.cc View 1 8 chunks +13 lines, -12 lines 0 comments Download
M views/view.h View 1 2 3 4 5 4 chunks +7 lines, -6 lines 0 comments Download
M views/view.cc View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M views/view_unittest.cc View 1 8 chunks +8 lines, -7 lines 0 comments Download
M views/views.gyp View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M views/widget/native_widget_gtk.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M views/widget/native_widget_win.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mazda
9 years, 1 month ago (2011-11-10 14:37:14 UTC) #1
Ben Goodger (Google)
LGTM with this one comment: http://codereview.chromium.org/8508055/diff/1/views/accelerator.h File views/accelerator.h (right): http://codereview.chromium.org/8508055/diff/1/views/accelerator.h#newcode24 views/accelerator.h:24: class VIEWS_EXPORT Accelerator : ...
9 years, 1 month ago (2011-11-10 22:02:25 UTC) #2
mazda
http://codereview.chromium.org/8508055/diff/1/views/accelerator.h File views/accelerator.h (right): http://codereview.chromium.org/8508055/diff/1/views/accelerator.h#newcode24 views/accelerator.h:24: class VIEWS_EXPORT Accelerator : public ui::Accelerator { On 2011/11/10 ...
9 years, 1 month ago (2011-11-11 13:09:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8508055/12001
9 years, 1 month ago (2011-11-14 08:21:15 UTC) #4
commit-bot: I haz the power
Can't process patch for file chrome/browser/chromeos/login/wizard_accessibility_helper.h. File's status is None, patchset upload is incomplete.
9 years, 1 month ago (2011-11-14 08:21:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/8508055/17001
9 years, 1 month ago (2011-11-14 08:35:15 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-14 08:35:18 UTC) #7 
Can't process patch for file
chrome/browser/chromeos/login/wizard_accessibility_helper.h.
File's status is None, patchset upload is incomplete.

Powered by Google App Engine
This is Rietveld 408576698