Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: runtime/vm/code_generator.cc

Issue 8508035: For instanceof inline check against right hand class id possible and interface String for OneByte... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_generator_ia32.cc » ('j') | runtime/vm/code_generator_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
===================================================================
--- runtime/vm/code_generator.cc (revision 1375)
+++ runtime/vm/code_generator.cc (working copy)
@@ -25,6 +25,7 @@
DEFINE_FLAG(bool, trace_patching, false, "Trace patching of code.");
DEFINE_FLAG(bool, trace_runtime_calls, false, "Trace runtime calls.");
DECLARE_FLAG(int, deoptimization_counter_threshold);
+DECLARE_FLAG(bool, trace_type_checks);
const Array& CodeGenerator::ArgumentsDescriptor(
@@ -325,6 +326,16 @@
const Bool& result = Bool::Handle(
instance.IsInstanceOf(type, type_instantiator) ?
Bool::True() : Bool::False());
+ if (FLAG_trace_type_checks) {
+ Class& cls = Class::Handle(instance.clazz());
+ // TODO(regis): Remove once all classes finalized.
+ if (cls.is_finalized()) {
+ OS::Print("InstanceOf '%s' vs '%s'\n",
regis 2011/11/10 03:09:51 You could use the result of the type test to print
srdjan 2011/11/10 17:24:41 Done.
+ String::Handle(Type::Handle(instance.GetType()).Name()).
+ ToCString(),
+ String::Handle(type.Name()).ToCString());
+ }
+ }
arguments.SetReturn(result);
}
« no previous file with comments | « no previous file | runtime/vm/code_generator_ia32.cc » ('j') | runtime/vm/code_generator_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698