For instanceof inline check against right hand class id possible and interface String for OneByte...

runtime/vm/code_generator.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/code_index_table.h"
 #include "vm/code_patcher.h"
 #include "vm/compiler.h"
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/exceptions.h"
 #include "vm/ic_data.h"
 #include "vm/object_store.h"
 #include "vm/resolver.h"
 #include "vm/runtime_entry.h"
 #include "vm/stack_frame.h"
 #include "vm/verifier.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, inline_cache, true, "enable inline caches");
 DEFINE_FLAG(bool, trace_deopt, false, "Trace deoptimization");
 DEFINE_FLAG(bool, trace_ic, false, "trace IC handling");
 DEFINE_FLAG(bool, trace_patching, false, "Trace patching of code.");
 DEFINE_FLAG(bool, trace_runtime_calls, false, "Trace runtime calls.");
 DECLARE_FLAG(int, deoptimization_counter_threshold);
+DECLARE_FLAG(bool, trace_type_checks);
 
 
 const Array& CodeGenerator::ArgumentsDescriptor(
     int num_arguments,
     const Array& optional_arguments_names) {
   const intptr_t num_named_args =
       optional_arguments_names.IsNull() ? 0 : optional_arguments_names.Length();
   const intptr_t num_pos_args = num_arguments - num_named_args;
 
   // Build the argument descriptor array, which consists of the total number of
@@ skipping 280 matching lines @@
   ASSERT(arguments.Count() == kInstanceofRuntimeEntry.argument_count());
   const Instance& instance = Instance::CheckedHandle(arguments.At(0));
   const Type& type = Type::CheckedHandle(arguments.At(1));
   const TypeArguments& type_instantiator =
       TypeArguments::CheckedHandle(arguments.At(2));
   ASSERT(type.IsFinalized());
   ASSERT(!instance.IsNull());
   const Bool& result = Bool::Handle(
       instance.IsInstanceOf(type, type_instantiator) ?
       Bool::True() : Bool::False());
+  if (FLAG_trace_type_checks) {
+    Class& cls = Class::Handle(instance.clazz());
+    // TODO(regis): Remove once all classes finalized.
+    if (cls.is_finalized())  {
+      OS::Print("InstanceOf '%s' vs '%s'\n",

[regis, 2011/11/10 03:09:51]

You could use the result of the type test to print "is" or "is !", instead of
"vs".

[srdjan, 2011/11/10 17:24:41]

Done.

+          String::Handle(Type::Handle(instance.GetType()).Name()).
+              ToCString(),
+          String::Handle(type.Name()).ToCString());
+    }
+  }
   arguments.SetReturn(result);
 }
 
 
 DEFINE_RUNTIME_ENTRY(Throw, 1) {
   ASSERT(arguments.Count() == kThrowRuntimeEntry.argument_count());
   const Instance& exception = Instance::CheckedHandle(arguments.At(0));
   Exceptions::Throw(exception);
 }
 
@@ skipping 643 matching lines @@
       }
     }
   }
   // The cache is null terminated, therefore the loop above should never
   // terminate by itself.
   UNREACHABLE();
   return Code::null();
 }
 
 }  // namespace dart