Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: gcl.py

Issue 8508017: Standardize the sys.path fix up and fix a few pylint warnings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Previous patchset was broken Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gcl.py
diff --git a/gcl.py b/gcl.py
index 64804a543957bfc27126b4f638e8e67c103e452a..368c5a3e9d12b9c8242b96bb765abf6b9876681c 100755
--- a/gcl.py
+++ b/gcl.py
@@ -278,7 +278,7 @@ class ChangeInfo(object):
rietveld: rietveld server for this change
"""
# Kept for unit test support. This is for the old format, it's deprecated.
- _SEPARATOR = "\n-----\n"
+ SEPARATOR = "\n-----\n"
def __init__(self, name, issue, patchset, description, files, local_root,
rietveld_url, needs_upload):
@@ -576,15 +576,15 @@ class ChangeInfo(object):
def _LoadOldFormat(content):
# The info files have the following format:
# issue_id, patchset\n (, patchset is optional)
- # _SEPARATOR\n
+ # SEPARATOR\n
# filepath1\n
# filepath2\n
# .
# .
# filepathn\n
- # _SEPARATOR\n
+ # SEPARATOR\n
# description
- split_data = content.split(ChangeInfo._SEPARATOR, 2)
+ split_data = content.split(ChangeInfo.SEPARATOR, 2)
if len(split_data) != 3:
raise ValueError('Bad change format')
values = {
« no previous file with comments | « no previous file | presubmit_support.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698