presubmit_support.py - Issue 8508017: Standardize the sys.path fix up and fix a few pylint warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 8508017: Standardize the sys.path fix up and fix a few pylint warnings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Previous patchset was broken Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index b2a94bc24b9b6f53a453cc98c4ede8295104a198..8adbd65d7de8be15212c5c82919cbfb5717063c1 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -662,7 +662,7 @@ class Change(object):

_AFFECTED_FILES = AffectedFile

# Matches key/value (or "tag") lines in changelist descriptions.

- _TAG_LINE_RE = re.compile(

+ TAG_LINE_RE = re.compile(

'^\s*(?P<key>[A-Z][A-Z_0-9]*)\s*=\s*(?P<value>.*?)\s*$')

scm = ''

@@ -683,7 +683,7 @@ class Change(object):

description_without_tags = []

self.tags = {}

for line in self._full_description.splitlines():

- m = self._TAG_LINE_RE.match(line)

+ m = self.TAG_LINE_RE.match(line)

if m:

self.tags[m.group('key')] = m.group('value')

else:

« no previous file with comments | « gcl.py ('k') | pylintrc » ('j') | no next file with comments »