Issue 8508017: Standardize the sys.path fix up and fix a few pylint warnings.

Issue 8508017: Standardize the sys.path fix up and fix a few pylint warnings. (Closed)

Created:
9 years, 1 month ago by M-A Ruel

Modified:
9 years, 1 month ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Standardize the sys.path fix up and fix a few pylint warnings. Disable temporarily W0403, will be reenabled on the next CL R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109435

Patch Set 2 : remove dead code #

Patch Set 3 : rebase against HEAD #

Total comments: 2

Patch Set 4 : Change import order #

Patch Set 5 : Previous patchset was broken #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -68 lines)			Patch
M	gcl.py	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	presubmit_support.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	pylintrc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/breakpad_unittest.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	tests/checkout_test.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/fix_encoding_test.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/gcl_unittest.py	View		7 chunks	+12 lines, -6 lines	0 comments	Download
M	tests/gclient_scm_test.py	View	1 2 3	3 chunks	+11 lines, -7 lines	0 comments	Download
M	tests/gclient_smoketest.py	View		3 chunks	+7 lines, -6 lines	0 comments	Download
M	tests/gclient_test.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	tests/gclient_utils_test.py	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/owners_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/patch_test.py	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	tests/presubmit_unittest.py	View	1	8 chunks	+12 lines, -7 lines	0 comments	Download
M	tests/rietveld_test.py	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/scm_unittest.py	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/subprocess2_test.py	View	1 2 3	3 chunks	+5 lines, -7 lines	0 comments	Download
M	tests/trychange_unittest.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	tests/watchlists_unittest.py	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

lgtm http://codereview.chromium.org/8508017/diff/22/tests/gclient_scm_test.py File tests/gclient_scm_test.py (right): http://codereview.chromium.org/8508017/diff/22/tests/gclient_scm_test.py#newcode15 tests/gclient_scm_test.py:15: from subprocess import Popen, PIPE, STDOUT Nit: I ...

9 years, 1 month ago (2011-11-09 23:18:47 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8508017/5001

9 years, 1 month ago (2011-11-10 15:35:39 UTC) #3

commit-bot: I haz the power

Can't apply patch for file depot_tools/third_party/upload.py. While running patch -p1 --forward --force; patching file depot_tools/third_party/upload.py ...

9 years, 1 month ago (2011-11-10 15:36:09 UTC) #4

M-A Ruel

http://codereview.chromium.org/8508017/diff/22/tests/gclient_scm_test.py File tests/gclient_scm_test.py (right): http://codereview.chromium.org/8508017/diff/22/tests/gclient_scm_test.py#newcode15 tests/gclient_scm_test.py:15: from subprocess import Popen, PIPE, STDOUT On 2011/11/09 23:18:47, ...

9 years, 1 month ago (2011-11-10 15:38:21 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8508017/7002

9 years, 1 month ago (2011-11-10 15:39:35 UTC) #6

Dirk Pranke

9 years, 1 month ago (2011-11-10 18:10:26 UTC) #8

On Thu, Nov 10, 2011 at 7:38 AM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/8508017/diff/22/tests/gclient_scm_test.py
> File tests/gclient_scm_test.py (right):
>
>
http://codereview.chromium.org/8508017/diff/22/tests/gclient_scm_test.py#newc...
> tests/gclient_scm_test.py:15: from subprocess import Popen, PIPE, STDOUT
> On 2011/11/09 23:18:47, Dirk Pranke wrote:
>>
>> Nit: I think all of the "from"s are supposed to be sorted before the
>
> "import"s.
>
> I think
> http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Imports
> is uninformative about that.
>
> I agree it's ugly. Fixing.
>

Hmm. I was looking at

http://code.google.com/p/soc/wiki/PythonStyleGuide#Imports_grouping_and_order

but that's not definitive.

-- Dirk

Expand Messages | Collapse Messages