Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 8508002: Observe per-script font preferences so WebKit settings are updated when they change. (Closed)

Created:
9 years, 1 month ago by falken
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Observe per-script font preferences so WebKit settings are updated when they change. Also, observe cursive/fantasy font prefs. This will help allow for more advanced font settings UI than are currently available, such as for per-script fonts. BUG=2685 TEST=manually, changed a per-script pref and saw it take effect Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109407

Patch Set 1 #

Patch Set 2 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/browser/ui/tab_contents/tab_contents_wrapper.cc View 1 3 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
falken
9 years, 1 month ago (2011-11-09 09:32:08 UTC) #1
sky
LGTM
9 years, 1 month ago (2011-11-09 15:40:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/8508002/2001
9 years, 1 month ago (2011-11-10 03:46:06 UTC) #3
commit-bot: I haz the power
Try job failure for 8508002-2001 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
9 years, 1 month ago (2011-11-10 05:35:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/8508002/2001
9 years, 1 month ago (2011-11-10 09:06:18 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-10 10:14:43 UTC) #6
Change committed as 109407

Powered by Google App Engine
This is Rietveld 408576698