Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc

Issue 8508002: Observe per-script font preferences so WebKit settings are updated when they change. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: formatting Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/tab_contents/tab_contents_wrapper.cc
diff --git a/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc b/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc
index 95b884675b21a2bcb081ea6f67568b9d6eb2f456..110f29e1f315d08460ccddd36049d07ce6124371 100644
--- a/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc
+++ b/chrome/browser/ui/tab_contents/tab_contents_wrapper.cc
@@ -78,8 +78,10 @@ const char* kPrefsToObserve[] = {
#endif
prefs::kWebKitAllowDisplayingInsecureContent,
prefs::kWebKitAllowRunningInsecureContent,
+ prefs::kWebKitCursiveFontFamily,
prefs::kWebKitDefaultFixedFontSize,
prefs::kWebKitDefaultFontSize,
+ prefs::kWebKitFantasyFontFamily,
prefs::kWebKitFixedFontFamily,
prefs::kWebKitJavaEnabled,
prefs::kWebKitJavascriptEnabled,
@@ -109,6 +111,17 @@ void RegisterFontFamilyMap(PrefService* prefs, const char* map_name) {
}
}
+// Registers |obs| to observe per-script font prefs under the path |map_name|.
+void RegisterFontFamilyMapObserver(PrefChangeRegistrar* registrar,
+ const char* map_name,
+ content::NotificationObserver* obs) {
+ for (size_t i = 0; i < prefs::kWebKitScriptsForFontFamilyMapsLength; ++i) {
+ const char* script = prefs::kWebKitScriptsForFontFamilyMaps[i];
+ std::string pref_name = base::StringPrintf("%s.%s", map_name, script);
+ registrar->Add(pref_name.c_str(), obs);
+ }
+}
+
struct PerScriptFontDefault {
const char* pref_name;
int resource_id;
@@ -319,6 +332,19 @@ TabContentsWrapper::TabContentsWrapper(TabContents* contents)
if (prefs) {
for (int i = 0; i < kPrefsToObserveLength; ++i)
pref_change_registrar_.Add(kPrefsToObserve[i], this);
+
+ RegisterFontFamilyMapObserver(&pref_change_registrar_,
+ prefs::kWebKitStandardFontFamilyMap, this);
+ RegisterFontFamilyMapObserver(&pref_change_registrar_,
+ prefs::kWebKitFixedFontFamilyMap, this);
+ RegisterFontFamilyMapObserver(&pref_change_registrar_,
+ prefs::kWebKitSerifFontFamilyMap, this);
+ RegisterFontFamilyMapObserver(&pref_change_registrar_,
+ prefs::kWebKitSansSerifFontFamilyMap, this);
+ RegisterFontFamilyMapObserver(&pref_change_registrar_,
+ prefs::kWebKitCursiveFontFamilyMap, this);
+ RegisterFontFamilyMapObserver(&pref_change_registrar_,
+ prefs::kWebKitFantasyFontFamilyMap, this);
}
renderer_preferences_util::UpdateFromSystemSettings(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698