src/mark-compact.cc - Issue 8507038: Fix Heap::Shrink to ensure that it does not free pages that are still in use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mark-compact.cc

Issue 8507038: Fix Heap::Shrink to ensure that it does not free pages that are still in use. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: get rid of last_unswept_page_, add comment about Heap::ReserveSpace Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/mark-compact.cc

diff --git a/src/mark-compact.cc b/src/mark-compact.cc

index c5364839892d32ada96e22b09aa80a0c5fc0835f..c98e389457db60ff810219ac8bc64f323da1a18b 100644

--- a/src/mark-compact.cc

+++ b/src/mark-compact.cc

@@ -3547,7 +3547,7 @@ void MarkCompactCollector::SweepSpace(PagedSpace* space,

case LAZY_CONSERVATIVE: {

freed_bytes += SweepConservatively(space, p);

if (freed_bytes >= newspace_size && p != space->LastPage()) {

- space->SetPagesToSweep(p->next_page(), space->anchor());

+ space->SetPagesToSweep(p->next_page());

lazy_sweeping_active = true;

}

break;

« no previous file with comments | « src/heap.cc ('k') | src/spaces.h » ('j') | src/spaces.cc » ('J')