src/heap.cc - Issue 8507038: Fix Heap::Shrink to ensure that it does not free pages that are still in use.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 8507038: Fix Heap::Shrink to ensure that it does not free pages that are still in use. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: get rid of last_unswept_page_, add comment about Heap::ReserveSpace Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 0cbe13f92fb26cdb730318ae56cde11cac517d23..be8dfecc0e67cac7e24270cbecf00e79558009f4 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -5609,8 +5609,11 @@ void Heap::TearDown() {

void Heap::Shrink() {

// Try to shrink all paged spaces.

PagedSpaces spaces;

- for (PagedSpace* space = spaces.next(); space != NULL; space = spaces.next())

+ for (PagedSpace* space = spaces.next();

+ space != NULL;

+ space = spaces.next()) {

space->ReleaseAllUnusedPages();

+ }

}

« no previous file with comments | « no previous file | src/mark-compact.cc » ('j') | src/spaces.cc » ('J')