Fix infinite spin in auth dialog.

When there is a password error and the user clicks the wrench menu to sign in again that would work with no bug. The reason it works is we end up calling the function ShowErrorUI on PSS which enumerates the errors(password, actionable, passphrase) and then calls the sync_setup_wizard's Step function with the right parameter.

However if the user goes to the options page and click sign in we call SyncSetupHandler::HandleShowErrorUI which bypasses PSS and simply calls SyncSetupWizard's step with a generic non_fatal_error parameter which does not do the right thing always. The fix is to simply route the entire thing through one function(which is in PSS currently. Once the code it ripped apart from PSS the logic would move along with it to the new class.)

added tests as well.

BUG=103628
TEST=manual testing, unit_tests.exe and sync_integration_tests.exe


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109689

[lipalani1, 2011-11-09 22:01:22]

Please review.

[tim (not reviewing), 2011-11-09 22:58:31]

This LGTM as a fix.  We really need to reduce the number of entry points to this
(e.g. bug 92265)! Fortunately refactoring the setup flow is something being
currently worked on. Adding Drew / James / Ben for comment / FYI.

[Andrew T Wilson (Slow), 2011-11-10 00:16:28]

LGTM for now also. Ultimately the wizard will go away and the guts will move up
into the UI anyway.

[commit-bot: I haz the power, 2011-11-10 04:02:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lipalani@chromium.org/8507026/2001

[commit-bot: I haz the power, 2011-11-10 05:50:52]

Try job failure for 8507026-2001 (retry) on win_rel for step
"chrome_frame_net_tests".
It's a second try, previously, step "chrome_frame_net_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2011-11-11 19:11:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lipalani@chromium.org/8507026/2001

[commit-bot: I haz the power, 2011-11-11 20:43:29]

Change committed as 109689