Fix infinite spin in auth dialog.

chrome/browser/sync/sync_setup_wizard_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_setup_wizard.h"
 
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/stl_util.h"
 #include "base/utf_string_conversions.h"
@@ skipping 128 matching lines @@
     user_chose_data_types_ = false;
     keep_everything_synced_ = false;
     chosen_data_types_.clear();
   }
 
   // Use this to have the service act as if it were running under CrOS.
   void set_cros_mode() {
     cros_user_ = kTestUser;
   }
 
+  virtual void ShowSyncSetup(const std::string& sub_page) {
+    // Do Nothing.
+  }
+
+  void ClearObservers() {
+    observers_.Clear();
+  }
+
+  SyncSetupWizard* GetWizard() {
+    return &wizard_;
+  }
+
   std::string username_;
   std::string password_;
   std::string captcha_;
   bool user_cancelled_dialog_;
   bool user_chose_data_types_;
   bool keep_everything_synced_;
   bool is_using_secondary_passphrase_;
   bool encrypt_everything_;
   syncable::ModelTypeSet chosen_data_types_;
-
   std::string passphrase_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncServiceForWizardTest);
 };
 
 class TestingProfileWithSyncService : public TestingProfile {
  public:
   TestingProfileWithSyncService() {
     sync_service_.reset(new ProfileSyncServiceForWizardTest(&factory_, this));
@@ skipping 19 matching lines @@
   virtual void SetUp() {
     set_profile(new TestingProfileWithSyncService());
     profile()->CreateBookmarkModel(false);
     // Wait for the bookmarks model to load.
     profile()->BlockUntilBookmarkModelLoaded();
     set_browser(new Browser(Browser::TYPE_TABBED, profile()));
     browser()->set_window(window());
     BrowserList::SetLastActive(browser());
     service_ = static_cast<ProfileSyncServiceForWizardTest*>(
         profile()->GetProfileSyncService());
-    wizard_.reset(new SyncSetupWizard(service_));
+    wizard_ = service_->GetWizard();
   }
 
   virtual void TearDown() {
-    wizard_.reset();
+    wizard_ = NULL;
     service_ = NULL;
     flow_ = NULL;
   }
 
  protected:
   void AttachSyncSetupHandler() {
     flow_ = wizard_->AttachSyncSetupHandler(&handler_);
   }
 
   void CompleteSetup() {
     // For a discrete run, we need to have ran through setup once.
     wizard_->Step(SyncSetupWizard::GAIA_LOGIN);
     AttachSyncSetupHandler();
     wizard_->Step(SyncSetupWizard::GAIA_SUCCESS);
     wizard_->Step(SyncSetupWizard::SYNC_EVERYTHING);
     wizard_->Step(SyncSetupWizard::SETTING_UP);
     wizard_->Step(SyncSetupWizard::DONE);
   }
 
   void CloseSetupUI() {
     handler_.CloseSetupUI();
   }
 
-  scoped_ptr<SyncSetupWizard> wizard_;
+  // This pointer is owned by the |Service_|.
+  SyncSetupWizard* wizard_;
   ProfileSyncServiceForWizardTest* service_;
   SyncSetupFlow* flow_;
   MockSyncSetupHandler handler_;
 };
 
 TEST_F(SyncSetupWizardTest, InitialStepLogin) {
   ListValue credentials;
   std::string auth = "{\"user\":\"";
   auth += std::string(kTestUser) + "\",\"pass\":\"";
   auth += std::string(kTestPassword) + "\",\"captcha\":\"";
@@ skipping 93 matching lines @@
   EXPECT_EQ(0U, service_->chosen_data_types_.count(syncable::PASSWORDS));
   EXPECT_EQ(0U, service_->chosen_data_types_.count(syncable::AUTOFILL));
   EXPECT_EQ(0U, service_->chosen_data_types_.count(syncable::EXTENSIONS));
   EXPECT_EQ(1U, service_->chosen_data_types_.count(syncable::TYPED_URLS));
   EXPECT_EQ(1U, service_->chosen_data_types_.count(syncable::APPS));
   EXPECT_EQ(0U, service_->chosen_data_types_.count(syncable::SEARCH_ENGINES));
   EXPECT_EQ(0U, service_->chosen_data_types_.count(
       syncable::APP_NOTIFICATIONS));
 }
 
+TEST_F(SyncSetupWizardTest, ShowErrorUIForPasswordTest) {
+  service_->ClearObservers();
+  CompleteSetup();
+
+  // Simulate an auth error and make sure the start and end state are set
+  // right.
+  service_->set_last_auth_error(
+      AuthError(GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS));
+  service_->ShowErrorUI();
+  AttachSyncSetupHandler();
+  EXPECT_EQ(SyncSetupWizard::GAIA_LOGIN, flow_->current_state_);
+  EXPECT_EQ(SyncSetupWizard::GAIA_SUCCESS, flow_->end_state_);
+  ASSERT_TRUE(wizard_->IsVisible());
+
+  // Make sure the wizard is dismissed.
+  wizard_->Step(SyncSetupWizard::GAIA_SUCCESS);
+  ASSERT_FALSE(wizard_->IsVisible());
+}
+
+TEST_F(SyncSetupWizardTest, ShowErrorUIForPassphraseTest) {
+  service_->ClearObservers();
+  CompleteSetup();
+
+  // Simulate a passphrase error and make sure the start and end state are set
+  // right and wizard is shown.
+  service_->set_passphrase_required_reason(sync_api::REASON_ENCRYPTION);
+  service_->set_is_using_secondary_passphrase(true);
+  service_->ShowErrorUI();
+  AttachSyncSetupHandler();
+  EXPECT_EQ(SyncSetupWizard::ENTER_PASSPHRASE, flow_->current_state_);
+  EXPECT_EQ(SyncSetupWizard::DONE, flow_->end_state_);
+  ASSERT_TRUE(wizard_->IsVisible());
+
+  // Make sure the wizard is dismissed.
+  wizard_->Step(SyncSetupWizard::DONE);
+  ASSERT_FALSE(wizard_->IsVisible());
+}
+
 TEST_F(SyncSetupWizardTest, EnterPassphraseRequired) {
   wizard_->Step(SyncSetupWizard::GAIA_LOGIN);
   AttachSyncSetupHandler();
   wizard_->Step(SyncSetupWizard::GAIA_SUCCESS);
   wizard_->Step(SyncSetupWizard::CONFIGURE);
   wizard_->Step(SyncSetupWizard::SETTING_UP);
   service_->set_passphrase_required_reason(sync_api::REASON_ENCRYPTION);
   wizard_->Step(SyncSetupWizard::ENTER_PASSPHRASE);
   EXPECT_EQ(SyncSetupWizard::ENTER_PASSPHRASE, flow_->current_state_);
 
@@ skipping 209 matching lines @@
 
   service_->set_last_auth_error(
       AuthError(GoogleServiceAuthError::SERVICE_UNAVAILABLE));
   wizard_->Step(SyncSetupWizard::NONFATAL_ERROR);
   AttachSyncSetupHandler();
   EXPECT_EQ(SyncSetupWizard::GAIA_LOGIN, flow_->current_state_);
   EXPECT_EQ(SyncSetupWizard::DONE, flow_->end_state_);
   CloseSetupUI();
   EXPECT_FALSE(wizard_->IsVisible());
 }