Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 8507013: Add WebCore log channels support to webkit_support. (Closed)

Created:
9 years, 1 month ago by gavinp
Modified:
9 years, 1 month ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add WebCore log channels support to webkit_support. I'm doing this in preparation for adding webcore logging channels to DumpRenderTree. I have the webkit CL ready, I'll upload it once this lands in Chrome. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webkit/support/webkit_support.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gavinp
Tony, Can you take a look at this for me? I want webcore logging sometimes ...
9 years, 1 month ago (2011-11-09 18:28:52 UTC) #1
tony
LGTM
9 years, 1 month ago (2011-11-09 18:36:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/8507013/1
9 years, 1 month ago (2011-11-09 18:37:47 UTC) #3
commit-bot: I haz the power
Try job failure for 8507013-1 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
9 years, 1 month ago (2011-11-09 20:34:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/8507013/1
9 years, 1 month ago (2011-11-10 22:57:30 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 00:49:53 UTC) #6
Change committed as 109550

Powered by Google App Engine
This is Rietveld 408576698