Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 8507007: MIPS: Tighten the code for MacroAssembler::ThrowUncatchable. (Closed)

Created:
9 years, 1 month ago by kisg
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Tighten the code for MacroAssembler::ThrowUncatchable. Port r9909 (56c8728aa). Original commit message: Test at the bottom in the unwind loop. Eliminate the possibility of a useless move to the eax/rax/r0 register (currently impossible because this function has two call sites). Do not explicitly zero the context because we've already saved 0 as the context in the handler. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9923

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -55 lines) Patch
M src/mips/macro-assembler-mips.cc View 2 chunks +23 lines, -55 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
kisg
9 years, 1 month ago (2011-11-09 10:41:54 UTC) #1
Kevin Millikin (Chromium)
Thanks for the patch. LGTM and I will land it. http://codereview.chromium.org/8507007/diff/1/src/mips/macro-assembler-mips.cc File src/mips/macro-assembler-mips.cc (right): http://codereview.chromium.org/8507007/diff/1/src/mips/macro-assembler-mips.cc#newcode2711 ...
9 years, 1 month ago (2011-11-09 11:03:10 UTC) #2
kisg
9 years, 1 month ago (2011-11-09 11:05:38 UTC) #3
On 2011/11/09 11:03:10, Kevin Millikin wrote:
> src/mips/macro-assembler-mips.cc:2711: isolate())));
> Indentation was off here, I'll fix it.

Thank you Kevin.

Best Regards,
Gergely

Powered by Google App Engine
This is Rietveld 408576698