chrome/browser/ui/panels/panel_browser_view.cc - Issue 8505047: Fix panels being removed from PanelManager prematurely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_browser_view.cc

Issue 8505047: Fix panels being removed from PanelManager prematurely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change test from using notification to timeout. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/panels/panel_browser_view.cc

diff --git a/chrome/browser/ui/panels/panel_browser_view.cc b/chrome/browser/ui/panels/panel_browser_view.cc

index b746c7e0f87b4ec539af27a0bd9c29dc42d51287..193c35e240aff490eb8f7664c93913f4acddab44 100644

--- a/chrome/browser/ui/panels/panel_browser_view.cc

+++ b/chrome/browser/ui/panels/panel_browser_view.cc

@@ -56,6 +56,7 @@ PanelBrowserView::PanelBrowserView(Browser* browser, Panel* panel,

}

PanelBrowserView::~PanelBrowserView() {

+ panel_->manager()->Remove(panel_.get());

}

void PanelBrowserView::Init() {