Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Side by Side Diff: chrome/browser/ui/panels/panel_browser_view.cc

Issue 8505047: Fix panels being removed from PanelManager prematurely. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change test from using notification to timeout. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/panels/panel_browser_view.h" 5 #include "chrome/browser/ui/panels/panel_browser_view.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "chrome/browser/ui/panels/panel.h" 9 #include "chrome/browser/ui/panels/panel.h"
10 #include "chrome/browser/ui/panels/panel_browser_frame_view.h" 10 #include "chrome/browser/ui/panels/panel_browser_frame_view.h"
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 bounds_(bounds), 49 bounds_(bounds),
50 closed_(false), 50 closed_(false),
51 focused_(false), 51 focused_(false),
52 mouse_pressed_(false), 52 mouse_pressed_(false),
53 mouse_dragging_state_(NO_DRAGGING), 53 mouse_dragging_state_(NO_DRAGGING),
54 is_drawing_attention_(false), 54 is_drawing_attention_(false),
55 old_focused_view_(NULL) { 55 old_focused_view_(NULL) {
56 } 56 }
57 57
58 PanelBrowserView::~PanelBrowserView() { 58 PanelBrowserView::~PanelBrowserView() {
59 panel_->manager()->Remove(panel_.get());
59 } 60 }
60 61
61 void PanelBrowserView::Init() { 62 void PanelBrowserView::Init() {
62 BrowserView::Init(); 63 BrowserView::Init();
63 64
64 GetWidget()->non_client_view()->SetAccessibleName( 65 GetWidget()->non_client_view()->SetAccessibleName(
65 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)); 66 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
66 } 67 }
67 68
68 void PanelBrowserView::Close() { 69 void PanelBrowserView::Close() {
(...skipping 473 matching lines...) Expand 10 before | Expand all | Expand 10 after
542 } 543 }
543 544
544 bool NativePanelTestingWin::IsWindowSizeKnown() const { 545 bool NativePanelTestingWin::IsWindowSizeKnown() const {
545 return true; 546 return true;
546 } 547 }
547 548
548 bool NativePanelTestingWin::IsAnimatingBounds() const { 549 bool NativePanelTestingWin::IsAnimatingBounds() const {
549 return panel_browser_view_->bounds_animator_.get() && 550 return panel_browser_view_->bounds_animator_.get() &&
550 panel_browser_view_->bounds_animator_->is_animating(); 551 panel_browser_view_->bounds_animator_->is_animating();
551 } 552 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/panels/panel.cc ('k') | chrome/browser/ui/panels/panel_browser_view_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698