Issue 8505016: chromeos: Add missing OVERRIDE annotation to classes implementing TabContentsDelegate::IsPopup

Issue 8505016: chromeos: Add missing OVERRIDE annotation to classes implementing TabContentsDelegate::IsPopup (Closed)

Created:
9 years, 1 month ago by tfarina

Modified:
9 years, 1 month ago

Reviewers:
Lei Zhang, stevenjb, DaveMoore, jianli

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Lei Zhang

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

chromeos: Add missing OVERRIDE annotation to classes implementing TabContentsDelegate::IsPopup BUG=100276 R=thestig@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109591

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	chrome/browser/chromeos/login/web_page_screen.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
	M	chrome/browser/chromeos/login/web_page_screen.cc	View		2 chunks	+1 line, -5 lines	0 comments	Download

Total messages: 9 (0 generated)

Lei Zhang

I'm not sure if we should remove IsPopup or rename it to IsPopupOrPanel. Deferring to ...

9 years, 1 month ago (2011-11-09 16:48:01 UTC) #2

tfarina

On 2011/11/09 16:48:01, Lei Zhang wrote: > I'm not sure if we should remove IsPopup ...

9 years, 1 month ago (2011-11-09 18:11:21 UTC) #3

tfarina

On 2011/11/10 00:53:03, tfarina wrote: > ping Steven? ?? Could someone rubber stamp this? Thanks!

9 years, 1 month ago (2011-11-10 20:38:40 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/8505016/3001

9 years, 1 month ago (2011-11-11 04:33:48 UTC) #8

Change committed as 109591