Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: chrome/browser/chromeos/login/web_page_screen.cc

Issue 8505016: chromeos: Add missing OVERRIDE annotation to classes implementing TabContentsDelegate::IsPopup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/chromeos/login/web_page_screen.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/web_page_screen.h" 5 #include "chrome/browser/chromeos/login/web_page_screen.h"
6 6
7 #include "base/time.h" 7 #include "base/time.h"
8 8
9 using base::TimeDelta; 9 using base::TimeDelta;
10 10
11 namespace chromeos { 11 namespace chromeos {
12 12
13 namespace { 13 namespace {
14 14
15 // Time in seconds after page load is considered timed out. 15 // Time in seconds after page load is considered timed out.
16 const int kNetworkTimeoutSec = 10; 16 const int kNetworkTimeoutSec = 10;
17 17
18 } // namespace 18 } // namespace
19 19
20 WebPageScreen::WebPageScreen() {} 20 WebPageScreen::WebPageScreen() {}
21 21
22 WebPageScreen::~WebPageScreen() {} 22 WebPageScreen::~WebPageScreen() {}
23 23
24 /////////////////////////////////////////////////////////////////////////////// 24 ///////////////////////////////////////////////////////////////////////////////
25 // WebPageScreen, TabContentsDelegate implementation: 25 // WebPageScreen, TabContentsDelegate implementation:
26 26
27 bool WebPageScreen::IsPopup(TabContents* source) {
28 return false;
29 }
30
31 bool WebPageScreen::ShouldAddNavigationToHistory( 27 bool WebPageScreen::ShouldAddNavigationToHistory(
32 const history::HistoryAddPageArgs& add_page_args, 28 const history::HistoryAddPageArgs& add_page_args,
33 content::NavigationType navigation_type) { 29 content::NavigationType navigation_type) {
34 return false; 30 return false;
35 } 31 }
36 32
37 bool WebPageScreen::HandleContextMenu(const ContextMenuParams& params) { 33 bool WebPageScreen::HandleContextMenu(const ContextMenuParams& params) {
38 // Just return true because we don't want to show context menue. 34 // Just return true because we don't want to show context menue.
39 return true; 35 return true;
40 } 36 }
(...skipping 14 matching lines...) Expand all
55 this, 51 this,
56 &WebPageScreen::OnNetworkTimeout); 52 &WebPageScreen::OnNetworkTimeout);
57 } 53 }
58 54
59 void WebPageScreen::StopTimeoutTimer() { 55 void WebPageScreen::StopTimeoutTimer() {
60 if (timeout_timer_.IsRunning()) 56 if (timeout_timer_.IsRunning())
61 timeout_timer_.Stop(); 57 timeout_timer_.Stop();
62 } 58 }
63 59
64 } // namespace chromeos 60 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/login/web_page_screen.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698