Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3132)

Unified Diff: chrome/browser/ui/browser.cc

Issue 8503018: Split DownloadItem into an ABC, an Impl, and a Mock. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merge Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 3f65a096c3a2f3558b083b1138d56e7ddac98cbc..a9ad4d8312cb84524f7825709dbbbfbf7e1e68d0 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -3648,7 +3648,7 @@ void Browser::OnStartDownload(TabContents* source, DownloadItem* download) {
if (!ChromeDownloadManagerDelegate::IsExtensionDownload(download) ||
(service == NULL) ||
!service->IsDownloadFromGallery(download->GetURL(),
- download->referrer_url())) {
+ download->GetReferrerUrl())) {
// Open the Active Downloads ui for chromeos.
ActiveDownloadsUI::OpenPopup(profile_);
}
@@ -3664,7 +3664,7 @@ void Browser::OnStartDownload(TabContents* source, DownloadItem* download) {
// Don't show the animation if the selected tab is not visible (i.e. the
// window is minimized, we're in a unit test, etc.).
TabContents* shelf_tab = shelf->browser()->GetSelectedTabContents();
- if ((download->total_bytes() > 0) &&
+ if ((download->GetTotalBytes() > 0) &&
!ChromeDownloadManagerDelegate::IsExtensionDownload(download) &&
platform_util::IsVisible(shelf_tab->GetNativeView()) &&
ui::Animation::ShouldRenderRichAnimation()) {
« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | chrome/browser/ui/cocoa/download/download_item_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698