Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4420)

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 8503018: Split DownloadItem into an ABC, an Impl, and a Mock. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: merge Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/download_protection_service.cc
diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc
index d9328a98f64bd2b149fd1caacc4b3ad7f5c29d92..d9aed52be1d6cc2dfc79960c601f9527f6e3f64d 100644
--- a/chrome/browser/safe_browsing/download_protection_service.cc
+++ b/chrome/browser/safe_browsing/download_protection_service.cc
@@ -146,12 +146,12 @@ DownloadProtectionService::DownloadInfo
DownloadProtectionService::DownloadInfo::FromDownloadItem(
const DownloadItem& item) {
DownloadInfo download_info;
- download_info.local_file = item.full_path();
download_info.target_file = item.GetTargetFilePath();
- download_info.download_url_chain = item.url_chain();
- download_info.referrer_url = item.referrer_url();
- download_info.sha256_hash = item.hash();
- download_info.total_bytes = item.total_bytes();
+ download_info.sha256_hash = item.GetHash();
+ download_info.local_file = item.GetFullPath();
+ download_info.download_url_chain = item.GetUrlChain();
+ download_info.referrer_url = item.GetReferrerUrl();
+ download_info.total_bytes = item.GetTotalBytes();
// TODO(bryner): Populate user_initiated
return download_info;
}
« no previous file with comments | « chrome/browser/download/save_page_browsertest.cc ('k') | chrome/browser/ui/browser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698