Show sync setup when user clicks Advanced link in bubble

chrome/browser/ui/webui/ntp/ntp_login_handler.cc

Index: chrome/browser/ui/webui/ntp/ntp_login_handler.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_login_handler.cc b/chrome/browser/ui/webui/ntp/ntp_login_handler.cc
index 8e88fe62a8482914483dbe2ff4cde57eb091c47f..662fae13bd0554049ee9dae1d125ee9f101423ce 100644
--- a/chrome/browser/ui/webui/ntp/ntp_login_handler.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_login_handler.cc
@@ -128,7 +128,10 @@ void NTPLoginHandler::HandleLoginMessageSeen(const ListValue* args) {
 }
 
 void NTPLoginHandler::HandleShowAdvancedLoginUI(const ListValue* args) {
-  Profile::FromWebUI(web_ui_)->GetProfileSyncService()->ShowLoginDialog();

[James Hawkins, 2011/11/08 16:55:44]

What does ShowLoginDialog() do differently?

[sail, 2011/11/08 18:42:50]

It calls SyncSetupWizard::Step(SyncSetupWizard::GAIA_LOGIN) which causes the
sync UI to show the login pane.

But yea, using OpenURL() here is not correct. It doesn't do thing like ensure
that only one copy of the settings UI is open at a time. I changed this to
ShowConfigure() which does this correctly.

+  std::string url(chrome::kChromeUISettingsURL);
+  url += chrome::kSyncSetupSubPage;
+  web_ui_->tab_contents()->OpenURL(GURL(url), GURL(), CURRENT_TAB,
+                                   content::PAGE_TRANSITION_LINK);
 }
 
 void NTPLoginHandler::UpdateLogin() {