Show sync setup when user clicks Advanced link in bubble

chrome/browser/ui/webui/ntp/ntp_login_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/ntp_login_handler.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 110 matching lines @@
                               NTP_SIGN_IN_PROMO_BUCKET_BOUNDARY);
   }
 }
 
 void NTPLoginHandler::HandleLoginMessageSeen(const ListValue* args) {
   Profile::FromWebUI(web_ui_)->GetPrefs()->SetBoolean(
       prefs::kSyncPromoShowNTPBubble, false);
 }
 
 void NTPLoginHandler::HandleShowAdvancedLoginUI(const ListValue* args) {
-  Profile::FromWebUI(web_ui_)->GetProfileSyncService()->ShowLoginDialog();

[James Hawkins, 2011/11/08 16:55:44]

What does ShowLoginDialog() do differently?

[sail, 2011/11/08 18:42:50]

It calls SyncSetupWizard::Step(SyncSetupWizard::GAIA_LOGIN) which causes the
sync UI to show the login pane.

But yea, using OpenURL() here is not correct. It doesn't do thing like ensure
that only one copy of the settings UI is open at a time. I changed this to
ShowConfigure() which does this correctly.

+  std::string url(chrome::kChromeUISettingsURL);
+  url += chrome::kSyncSetupSubPage;
+  web_ui_->tab_contents()->OpenURL(GURL(url), GURL(), CURRENT_TAB,
+                                   content::PAGE_TRANSITION_LINK);
 }
 
 void NTPLoginHandler::UpdateLogin() {
   Profile* profile = Profile::FromWebUI(web_ui_);
   std::string username = profile->GetPrefs()->GetString(
       prefs::kGoogleServicesUsername);
 
   string16 header, sub_header;
   if (!username.empty()) {
     header = UTF8ToUTF16(username);
@@ skipping 47 matching lines @@
           l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME)));
   values->SetString("login_status_url",
       google_util::StringAppendGoogleLocaleParam(chrome::kSyncLearnMoreURL));
   values->SetString("login_status_learn_more",
       l10n_util::GetStringUTF16(IDS_LEARN_MORE));
   values->SetString("login_status_advanced",
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_ADVANCED));
   values->SetString("login_status_dismiss",
       l10n_util::GetStringUTF16(IDS_SYNC_PROMO_NTP_BUBBLE_OK));
 }