Show sync setup when user clicks Advanced link in bubble

Show sync setup when user clicks Advanced link in bubble

BUG=103318
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109096

[James Hawkins, 2011-11-08 16:55:44]

http://codereview.chromium.org/8502007/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_login_handler.cc (left):

http://codereview.chromium.org/8502007/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_login_handler.cc:131:
Profile::FromWebUI(web_ui_)->GetProfileSyncService()->ShowLoginDialog();
What does ShowLoginDialog() do differently?

[sail, 2011-11-08 18:42:44]

http://codereview.chromium.org/8502007/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_login_handler.cc (left):

http://codereview.chromium.org/8502007/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_login_handler.cc:131:
Profile::FromWebUI(web_ui_)->GetProfileSyncService()->ShowLoginDialog();
On 2011/11/08 16:55:44, James Hawkins wrote:
> What does ShowLoginDialog() do differently?

It calls SyncSetupWizard::Step(SyncSetupWizard::GAIA_LOGIN) which causes the
sync UI to show the login pane.

But yea, using OpenURL() here is not correct. It doesn't do thing like ensure
that only one copy of the settings UI is open at a time. I changed this to
ShowConfigure() which does this correctly.

[James Hawkins, 2011-11-08 19:21:01]

Thanks for the fix.  LGTM

[commit-bot: I haz the power, 2011-11-08 19:22:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8502007/2003

[commit-bot: I haz the power, 2011-11-08 21:05:36]

Change committed as 109096