runtime/vm/isolate.cc - Issue 8501034: Deal with unhandled exceptions the same way in all Dart api functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 8501034: Deal with unhandled exceptions the same way in all Dart api functions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/isolate.cc

===================================================================

--- runtime/vm/isolate.cc (revision 1469)

+++ runtime/vm/isolate.cc (working copy)

@@ -246,8 +246,12 @@

PortMessage* message = message_queue()->Dequeue(0);

if (message != NULL) {

- Dart_HandleMessage(

+ Dart_Handle result = Dart_HandleMessage(

message->dest_port(), message->reply_port(), message->data());

+ if (Dart_IsError(result)) {

+ fprintf(stderr, "%s\n", Dart_GetError(result));

+ exit(255);

+ }

delete message;

}

« no previous file with comments | « runtime/vm/exceptions_test.cc ('k') | runtime/vm/isolate_test.cc » ('j') | no next file with comments »