Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: runtime/vm/exceptions_test.cc

Issue 8501034: Deal with unhandled exceptions the same way in all Dart api functions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/exceptions_test.cc
===================================================================
--- runtime/vm/exceptions_test.cc (revision 1469)
+++ runtime/vm/exceptions_test.cc (working copy)
@@ -35,8 +35,8 @@
Dart_NewString("method2"),
0,
NULL);
- ASSERT(Dart_IsValid(result));
- ASSERT(Dart_ExceptionOccurred(result));
+ ASSERT(Dart_IsError(result));
+ ASSERT(Dart_ErrorHasException(result));
return;
}
@@ -48,10 +48,10 @@
Dart_NewString("method2"),
0,
NULL);
- ASSERT(Dart_IsValid(result));
- ASSERT(Dart_ExceptionOccurred(result));
- Dart_Handle exception = Dart_GetException(result);
- ASSERT(Dart_IsValid(exception));
+ ASSERT(Dart_IsError(result));
+ ASSERT(Dart_ErrorHasException(result));
+ Dart_Handle exception = Dart_ErrorGetException(result);
+ ASSERT(!Dart_IsError(exception));
Dart_ThrowException(exception);
UNREACHABLE();
return;
« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | runtime/vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698