Issue 8501006: Disentangle header dependecies a bit by moving PropertyDetails-related types into a separate header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8501006: Disentangle header dependecies a bit by moving PropertyDetails-related types into a separate header (Closed)

Created:
9 years, 1 month ago by Sven Panne

Modified:
9 years, 1 month ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Disentangle header dependecies a bit by moving PropertyDetails-related types into a separate header This moves PropertyType and its related predicate out of v8globals.h, where it didn't belong. Committed: http://code.google.com/p/v8/source/detail?r=9907

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+165 lines, -119 lines)			Patch
M	src/objects.h	View	3 chunks	+1 line, -76 lines	0 comments	Download
A	src/property-details.h	View	1 chunk	+163 lines, -0 lines	0 comments	Download
M	src/v8globals.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. The SCons build should just work, because it doesn't need to be told explicitly ...

9 years, 1 month ago (2011-11-08 10:29:11 UTC) #2

Sven Panne

9 years, 1 month ago (2011-11-08 10:40:17 UTC) #3

On 2011/11/08 10:29:11, Kevin Millikin wrote:
> LGTM.
> 
> The SCons build should just work, because it doesn't need to be told
explicitly
> about headers, but you might want to verify that.

I'm still a SCons-guy, so I'm sure it works. :)

Expand Messages | Collapse Messages