Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 8497014: Adds proper IPC usage for AudioDevice::GetAudioHardwareBufferSize(). (Closed)

Created:
9 years, 1 month ago by henrika (OOO until Aug 14)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org, Chris Rogers, Raymond Toy (Google)
Visibility:
Public.

Description

Adds proper IPC usage for AudioDevice::GetAudioHardwareBufferSize(). This method did previously call directly into media/audio. BUG=none TEST=WebAudio demo in multi-process mode Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109388

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixes indentation error #

Total comments: 1

Patch Set 3 : Replaced size_t with uint32 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/audio_device.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
henrika (OOO until Aug 14)
Avoids an existing crash in AudioDevice::GetAudioHardwareBufferSize() which asks for the current hardware sample rate. For ...
9 years, 1 month ago (2011-11-08 14:29:32 UTC) #1
tommi (sloooow) - chröme
lgtm http://codereview.chromium.org/8497014/diff/1/content/common/view_messages.h File content/common/view_messages.h (right): http://codereview.chromium.org/8497014/diff/1/content/common/view_messages.h#newcode686 content/common/view_messages.h:686: size_t /* buffer_size */) fix indent
9 years, 1 month ago (2011-11-08 14:31:30 UTC) #2
henrika (OOO until Aug 14)
John and Andrew: I would appreciate a quick check here. Should be trivial I hope. ...
9 years, 1 month ago (2011-11-08 16:29:54 UTC) #3
Raymond Toy (Google)
This patch fixes, of course, the crash I was getting. The couple of webaudio demos ...
9 years, 1 month ago (2011-11-08 18:05:40 UTC) #4
jam
http://codereview.chromium.org/8497014/diff/7/content/common/view_messages.h File content/common/view_messages.h (right): http://codereview.chromium.org/8497014/diff/7/content/common/view_messages.h#newcode686 content/common/view_messages.h:686: size_t /* buffer_size */) we avoid size_t in message ...
9 years, 1 month ago (2011-11-08 18:31:31 UTC) #5
scherkus (not reviewing)
LGTM but jam@'s comment still stands
9 years, 1 month ago (2011-11-09 00:56:27 UTC) #6
henrika (OOO until Aug 14)
John, please check again. Modified from size_t to unit32.
9 years, 1 month ago (2011-11-09 10:03:07 UTC) #7
tommi (sloooow) - chröme
lgtm
9 years, 1 month ago (2011-11-09 10:04:00 UTC) #8
jam
9 years, 1 month ago (2011-11-09 17:43:44 UTC) #9
lgtm

Powered by Google App Engine
This is Rietveld 408576698