Add unit tests for SetAutoRepeatEnabled and SetAutoRepeatRate.

Add unit tests for SetAutoRepeatEnabled and SetAutoRepeatRate.

BUG=None
TEST=ran try


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109844

[Zachary Kuznia, 2011-11-08 03:55:16]

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/xkeyboard.cc (right):

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard.cc:380:
&(out_rate->repeat_interval_in_ms)) == True;
Why "True" instead of "true"?

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/xkeyboard_unittest.cc (right):

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard_unittest.cc:359: if
(!DisplayAvailable()) {
Should this fail the test?

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard_unittest.cc:371: if
(!DisplayAvailable()) {
ditto

[Yusuke Sato, 2011-11-13 23:24:56]

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/xkeyboard.cc (right):

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard.cc:380:
&(out_rate->repeat_interval_in_ms)) == True;
On 2011/11/08 03:55:17, Zachary Kuznia wrote:
> Why "True" instead of "true"?

because Xlib/XKB functions return True/False instead of C++ true/false.

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
File chrome/browser/chromeos/input_method/xkeyboard_unittest.cc (right):

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard_unittest.cc:359: if
(!DisplayAvailable()) {
On 2011/11/08 03:55:17, Zachary Kuznia wrote:
> Should this fail the test?

The intension of this check is that to allow developers to run unit_tests
without an X server (e.g. via ssh). Please note that both try bots and waterfall
always have an X server for running browser_tests.

I've added a comment and a LOG.

http://codereview.chromium.org/8497003/diff/1004/chrome/browser/chromeos/inpu...
chrome/browser/chromeos/input_method/xkeyboard_unittest.cc:371: if
(!DisplayAvailable()) {
On 2011/11/08 03:55:17, Zachary Kuznia wrote:
> ditto

the same as above.

[Zachary Kuznia, 2011-11-14 01:58:30]

lgtm

[commit-bot: I haz the power, 2011-11-14 02:24:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yusukes@chromium.org/8497003/12001

[commit-bot: I haz the power, 2011-11-14 04:02:28]

Change committed as 109844