Add unit tests for SetAutoRepeatEnabled and SetAutoRepeatRate.

chrome/browser/chromeos/input_method/xkeyboard.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/xkeyboard.h"
 
 #include <queue>
 #include <set>
 #include <string>
 #include <utility>
@@ skipping 335 matching lines @@
     XAutoRepeatOn(ui::GetXDisplay());
   } else {
     XAutoRepeatOff(ui::GetXDisplay());
   }
   DLOG(INFO) << "Set auto-repeat mode to: " << (enabled ? "on" : "off");
   return true;
 }
 
 // static
 bool XKeyboard::SetAutoRepeatRate(const AutoRepeatRate& rate) {
-  // TODO(yusukes): write auto tests for the function.
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DLOG(INFO) << "Set auto-repeat rate to: "
              << rate.initial_delay_in_ms << " ms delay, "
              << rate.repeat_interval_in_ms << " ms interval";
   if (XkbSetAutoRepeatRate(ui::GetXDisplay(), XkbUseCoreKbd,
                            rate.initial_delay_in_ms,
                            rate.repeat_interval_in_ms) != True) {
     LOG(ERROR) << "Failed to set auto-repeat rate";
     return false;
   }
   return true;
 }
 
+// static
+bool XKeyboard::GetAutoRepeatEnabled() {
+  XKeyboardState state = {};
+  XGetKeyboardControl(ui::GetXDisplay(), &state);
+  return state.global_auto_repeat != AutoRepeatModeOff;
+}
+
+// static
+bool XKeyboard::GetAutoRepeatRate(AutoRepeatRate* out_rate) {
+  return XkbGetAutoRepeatRate(ui::GetXDisplay(), XkbUseCoreKbd,
+                              &(out_rate->initial_delay_in_ms),
+                              &(out_rate->repeat_interval_in_ms)) == True;

[Zachary Kuznia, 2011/11/08 03:55:17]

Why "True" instead of "true"?

[Yusuke Sato, 2011/11/13 23:24:56]

because Xlib/XKB functions return True/False instead of C++ true/false.

+}
+
 void XKeyboard::SetLockedModifiers(ModifierLockStatus new_caps_lock_status,
                                    ModifierLockStatus new_num_lock_status) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if (!num_lock_mask_) {
     LOG(ERROR) << "Cannot set locked modifiers. Num Lock mask unknown.";
     return;
   }
 
   unsigned int affect_mask = 0;
   unsigned int value_mask = 0;
@@ skipping 134 matching lines @@
     case kCapsLockKey:
       return "capslock";
     case kNumModifierKeys:
       break;
   }
   return "";
 }
 
 }  // namespace input_method
 }  // namespace chromeos