Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: webkit/glue/webmediaplayer_impl.cc

Issue 8496044: Repaint video controls when buffering during pause. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fix v2. Rely on HTMLMediaElement timer. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webmediaplayer_impl.cc
diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc
index 01ddcc06c9191fef3966592df87892058792b880..e6b17813e2fa1481e11c01029e95d504179333ba 100644
--- a/webkit/glue/webmediaplayer_impl.cc
+++ b/webkit/glue/webmediaplayer_impl.cc
@@ -395,6 +395,11 @@ void WebMediaPlayerImpl::setVolume(float volume) {
void WebMediaPlayerImpl::setVisible(bool visible) {
DCHECK_EQ(main_loop_, MessageLoop::current());
+ // Update controls as data buffers when paused. HTMLMediaElement issues a
+ // RenderVideo->updateFromElement() which ends in a call to here.
scherkus (not reviewing) 2011/11/16 02:09:25 I think the part I'm more interested in is when/wh
DaleCurtis 2011/11/16 02:31:49 Done.
+ if (visible && paused_)
+ Repaint();
+
// TODO(hclam): add appropriate method call when pipeline has it implemented.
scherkus (not reviewing) 2011/11/16 02:09:25 do you know what this TODO might be referring to?
DaleCurtis 2011/11/16 02:31:49 I sent him an email. I'll report back. On 2011/11
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698