Repaint video controls when buffering during pause.

webkit/glue/webmediaplayer_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webmediaplayer_impl.h"
 
 #include <limits>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 377 matching lines @@
 
 void WebMediaPlayerImpl::setVolume(float volume) {
   DCHECK_EQ(main_loop_, MessageLoop::current());
 
   pipeline_->SetVolume(volume);
 }
 
 void WebMediaPlayerImpl::setVisible(bool visible) {
   DCHECK_EQ(main_loop_, MessageLoop::current());
 
+  // Update controls as data buffers when paused. HTMLMediaElement issues a
+  // RenderVideo->updateFromElement() which ends in a call to here.

[scherkus (not reviewing), 2011/11/16 02:09:25]

I think the part I'm more interested in is when/why does it issue this call?

[DaleCurtis, 2011/11/16 02:31:49]

Done.

+  if (visible && paused_)
+    Repaint();
+
   // TODO(hclam): add appropriate method call when pipeline has it implemented.

[scherkus (not reviewing), 2011/11/16 02:09:25]

do you know what this TODO might be referring to?

perhaps it's time to remove it!

[DaleCurtis, 2011/11/16 02:31:49]

I sent him an email. I'll report back.

On 2011/11/16 02:09:25, scherkus wrote:

   return;
 }
 
 #define COMPILE_ASSERT_MATCHING_ENUM(webkit_name, chromium_name) \
     COMPILE_ASSERT(static_cast<int>(WebKit::WebMediaPlayer::webkit_name) == \
                    static_cast<int>(media::chromium_name), \
                    mismatching_enums)
 COMPILE_ASSERT_MATCHING_ENUM(None, NONE);
 COMPILE_ASSERT_MATCHING_ENUM(MetaData, METADATA);
 COMPILE_ASSERT_MATCHING_ENUM(Auto, AUTO);
@@ skipping 459 matching lines @@
   return client_;
 }
 
 void WebMediaPlayerImpl::IncrementExternallyAllocatedMemory() {
   DCHECK_EQ(main_loop_, MessageLoop::current());
   incremented_externally_allocated_memory_ = true;
   v8::V8::AdjustAmountOfExternalAllocatedMemory(kPlayerExtraMemory);
 }
 
 }  // namespace webkit_glue