Report ERR_CONTENT_LENGTH_MISMATCH when the count of bytes received doesn't match Content-Length.

net/http/http_stream_parser.cc

Index: net/http/http_stream_parser.cc
diff --git a/net/http/http_stream_parser.cc b/net/http/http_stream_parser.cc
index 2a862204ff89bdc415a07f5ebad0f52d22070ecf..690ba1421e2f3e9a01119479673be6ea05dd0ac7 100644
--- a/net/http/http_stream_parser.cc
+++ b/net/http/http_stream_parser.cc
@@ -535,7 +535,7 @@ int HttpStreamParser::DoReadBodyComplete(int result) {
   // so we don't treat that as an error, though in some cases we may not
   // have completely received the resource.
   if (result == 0 && !IsResponseBodyComplete() && CanFindEndOfResponse())

[rvargas (doing something else), 2011/11/08 23:27:47]

This not only includes content-length mismatch, but also problems detected by
the chunked_decoder. We should probably return ERR_CONNECTION_CLOSED for chunk
mismatches, or add a new error code.

[cbentzel, 2011/11/09 01:26:09]

Good point. I could imagine a new error code. I'll adjust my test server to do
bad chunked encoding and see what the behavior is on other browsers before
making a decision here.

[cbentzel, 2011/11/09 18:17:36]

I tested with FF4 and FF8. Need to test with other browsers.

If chunked-encoding advertises too few bytes in the chunk [i.e. advertises 8\r\n
but actually sends a 16 byte chunk] FF4 will not show the page but FF8 will.
Similar behavior exists for octet-streams.

If chunked-encoding advertised more bytes than are actually sent before the
connection closes, both FF4 and FF8 show whatever content was received.

I think it makes sense to report ERR_INVALID_CHUNKED_ENCODING here, and treat
like that an error. If we end up getting some pushback that this is hurting
users, we can ignore it for certain resource fetches as well.

[cbentzel, 2011/11/09 18:48:35]

Safari 5.1.1 on Windows will fail if the Chunked-Encoding advertises too few or
too many bytes. However, it will not fail if the Content-Length is higher than
the number of bytes received. 

Now that this is reporting ERR_INVALID_CHUNKED_ENCODING for one case and
ERR_CONTENT_LENGTH_MISMATCH the behavior will match that.

-    result = ERR_CONNECTION_CLOSED;
+    result = ERR_CONTENT_LENGTH_MISMATCH;
 
   // Filter incoming data if appropriate.  FilterBuf may return an error.
   if (result > 0 && chunked_decoder_.get()) {