Report ERR_CONTENT_LENGTH_MISMATCH when the count of bytes received doesn't match Content-Length.

net/http/http_stream_parser.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_parser.h"
 
 #include "base/compiler_specific.h"
 #include "base/metrics/histogram.h"
 #include "base/stringprintf.h"
 #include "base/string_util.h"
@@ skipping 516 matching lines @@
   DCHECK_EQ(0, read_buf_->offset());
   return connection_->socket()->Read(user_read_buf_, user_read_buf_len_,
                                      &io_callback_);
 }
 
 int HttpStreamParser::DoReadBodyComplete(int result) {
   // If we didn't get a Content-Length and aren't using a chunked encoding,
   // the only way to signal the end of a stream is to close the connection,
   // so we don't treat that as an error, though in some cases we may not
   // have completely received the resource.
   if (result == 0 && !IsResponseBodyComplete() && CanFindEndOfResponse())

[rvargas (doing something else), 2011/11/08 23:27:47]

This not only includes content-length mismatch, but also problems detected by
the chunked_decoder. We should probably return ERR_CONNECTION_CLOSED for chunk
mismatches, or add a new error code.

[cbentzel, 2011/11/09 01:26:09]

Good point. I could imagine a new error code. I'll adjust my test server to do
bad chunked encoding and see what the behavior is on other browsers before
making a decision here.

[cbentzel, 2011/11/09 18:17:36]

I tested with FF4 and FF8. Need to test with other browsers.

If chunked-encoding advertises too few bytes in the chunk [i.e. advertises 8\r\n
but actually sends a 16 byte chunk] FF4 will not show the page but FF8 will.
Similar behavior exists for octet-streams.

If chunked-encoding advertised more bytes than are actually sent before the
connection closes, both FF4 and FF8 show whatever content was received.

I think it makes sense to report ERR_INVALID_CHUNKED_ENCODING here, and treat
like that an error. If we end up getting some pushback that this is hurting
users, we can ignore it for certain resource fetches as well.

[cbentzel, 2011/11/09 18:48:35]

Safari 5.1.1 on Windows will fail if the Chunked-Encoding advertises too few or
too many bytes. However, it will not fail if the Content-Length is higher than
the number of bytes received. 

Now that this is reporting ERR_INVALID_CHUNKED_ENCODING for one case and
ERR_CONTENT_LENGTH_MISMATCH the behavior will match that.

-    result = ERR_CONNECTION_CLOSED;
+    result = ERR_CONTENT_LENGTH_MISMATCH;
 
   // Filter incoming data if appropriate.  FilterBuf may return an error.
   if (result > 0 && chunked_decoder_.get()) {
     result = chunked_decoder_->FilterBuf(user_read_buf_->data(), result);
     if (result == 0 && !chunked_decoder_->reached_eof()) {
       // Don't signal completion of the Read call yet or else it'll look like
       // we received end-of-file.  Wait for more data.
       io_state_ = STATE_READ_BODY;
       return OK;
     }
@@ skipping 213 matching lines @@
 void HttpStreamParser::GetSSLCertRequestInfo(
     SSLCertRequestInfo* cert_request_info) {
   if (request_->url.SchemeIs("https") && connection_->socket()) {
     SSLClientSocket* ssl_socket =
         static_cast<SSLClientSocket*>(connection_->socket());
     ssl_socket->GetSSLCertRequestInfo(cert_request_info);
   }
 }
 
 }  // namespace net