Sync: Improve handling of database load failures

chrome/browser/sync/profile_sync_service.h

Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index d1609163c5de4880108ae6eff5e9143bf1af8863..01ec6168fb8845218aca1e80b1087fa0ff8ede98 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -505,8 +505,9 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
   // Starts up the backend sync components.
   void StartUp();
   // Shuts down the backend sync components.
-  // |sync_disabled| indicates if syncing is being disabled or not.
-  void Shutdown(bool sync_disabled);
+  // |delete_stale_data| indicates whether or not we should delete the current
+  // sync database.

[Nicolas Zea, 2011/11/08 22:12:18]

Elaborate a bit about why you would ever want to set delete_stale_data to true.

[rlarocque, 2011/11/11 22:24:56]

I've decided not to do this rename.  Instead I will call DisableForUser() from
the backend initialization failure.

+  void Shutdown(bool delete_stale_data);
 
   // Return SyncCredentials from the TokenService.
   sync_api::SyncCredentials GetCredentials();