Sync: Improve handling of database load failures

chrome/browser/sync/profile_sync_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #define CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_
 #pragma once
 
 #include <list>
 #include <string>
@@ skipping 487 matching lines @@
  protected:
   // Used by test classes that derive from ProfileSyncService.
   virtual browser_sync::SyncBackendHost* GetBackendForTest();
 
   // Helper to install and configure a data type manager.
   void ConfigureDataTypeManager();
 
   // Starts up the backend sync components.
   void StartUp();
   // Shuts down the backend sync components.
-  // |sync_disabled| indicates if syncing is being disabled or not.
-  void Shutdown(bool sync_disabled);
+  // |delete_stale_data| indicates whether or not we should delete the current
+  // sync database.

[Nicolas Zea, 2011/11/08 22:12:18]

Elaborate a bit about why you would ever want to set delete_stale_data to true.

[rlarocque, 2011/11/11 22:24:56]

I've decided not to do this rename.  Instead I will call DisableForUser() from
the backend initialization failure.

+  void Shutdown(bool delete_stale_data);
 
   // Return SyncCredentials from the TokenService.
   sync_api::SyncCredentials GetCredentials();
 
   // Test need to override this to create backends that allow setting up
   // initial conditions, such as populating sync nodes.
   //
   // TODO(akalin): Figure out a better way to do this.  Ideally, we'd
   // construct the backend outside this class and pass it in to the
   // contructor or Initialize().
@@ skipping 196 matching lines @@
   FailedDatatypesHandler failed_datatypes_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
 };
 
 bool ShouldShowActionOnUI(
     const browser_sync::SyncProtocolError& error);
 
 
 #endif  // CHROME_BROWSER_SYNC_PROFILE_SYNC_SERVICE_H_